Bug 200508

Summary: RegisterSet should be constexpr
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED LATER    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mark.lam, msaboff, saam, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch
none
Patch
none
Patch none

Description Keith Miller 2019-08-07 11:14:55 PDT
RegisterSet should be constexpr
Comment 1 Keith Miller 2019-08-07 11:16:07 PDT
Created attachment 375716 [details]
Patch
Comment 2 Saam Barati 2019-08-07 11:19:23 PDT
Comment on attachment 375716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review

very nice

> Source/JavaScriptCore/jit/RegisterSet.h:251
> +namespace JSC {

style nit: newline after this

> Source/JavaScriptCore/jit/RegisterSet.h:545
> +}

nit: // namespace JSC
Comment 3 Keith Miller 2019-08-07 11:36:58 PDT
Created attachment 375723 [details]
Patch for landing
Comment 4 Keith Miller 2019-08-07 11:38:16 PDT
Created attachment 375725 [details]
Patch
Comment 5 Keith Miller 2019-08-07 11:50:18 PDT
Created attachment 375727 [details]
Patch
Comment 6 Keith Miller 2019-08-07 12:51:27 PDT
Created attachment 375734 [details]
Patch
Comment 7 Keith Miller 2019-08-07 14:09:28 PDT
Created attachment 375752 [details]
Patch
Comment 8 Keith Miller 2019-08-07 14:57:27 PDT
Nvm, we can't do this because old Clang is broken... :(