Summary: | RegisterSet should be constexpr | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||||||
Status: | RESOLVED LATER | ||||||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mark.lam, msaboff, saam, tzagallo | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Keith Miller
2019-08-07 11:14:55 PDT
Created attachment 375716 [details]
Patch
Comment on attachment 375716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review very nice > Source/JavaScriptCore/jit/RegisterSet.h:251 > +namespace JSC { style nit: newline after this > Source/JavaScriptCore/jit/RegisterSet.h:545 > +} nit: // namespace JSC Created attachment 375723 [details]
Patch for landing
Created attachment 375725 [details]
Patch
Created attachment 375727 [details]
Patch
Created attachment 375734 [details]
Patch
Created attachment 375752 [details]
Patch
Nvm, we can't do this because old Clang is broken... :( |