Bug 200508

Summary:

RegisterSet should be constexpr

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED LATER

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mark.lam, msaboff, saam, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Keith Miller

Reported 2019-08-07 11:14:55 PDT

RegisterSet should be constexpr

Attachments
Patch (52.18 KB, patch) 2019-08-07 11:16 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (52.33 KB, patch) 2019-08-07 11:36 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (52.33 KB, patch) 2019-08-07 11:38 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (52.23 KB, patch) 2019-08-07 11:50 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (53.20 KB, patch) 2019-08-07 12:51 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (53.29 KB, patch) 2019-08-07 14:09 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2019-08-07 11:16:07 PDT

Saam Barati

Comment 2 2019-08-07 11:19:23 PDT

Comment on attachment 375716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review very nice > Source/JavaScriptCore/jit/RegisterSet.h:251 > +namespace JSC { style nit: newline after this > Source/JavaScriptCore/jit/RegisterSet.h:545 > +} nit: // namespace JSC

Keith Miller

Comment 3 2019-08-07 11:36:58 PDT

Created attachment 375723 [details] Patch for landing

Keith Miller

Comment 4 2019-08-07 11:38:16 PDT

Keith Miller

Comment 5 2019-08-07 11:50:18 PDT

Keith Miller

Comment 6 2019-08-07 12:51:27 PDT