Bug 200505

Summary: Add more threading assertions to ITP code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-08-07 08:51:43 PDT
Add more threading assertions to ITP code to help cache bugs and protect against future bad usage.
Attachments
Patch (14.42 KB, patch)
2019-08-07 08:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.42 KB, patch)
2019-08-07 09:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-08-07 08:52:28 PDT
Created attachment 375700 [details] Patch
Brent Fulgham
Comment 2 2019-08-07 09:23:25 PDT
Comment on attachment 375700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375700&action=review r=mews. > Source/WebKit/ChangeLog:8 > + Add more threading assertions to ITP code to help cache bugs and protect against future bad usage. cache bugs? or catch bugs?
Chris Dumez
Comment 3 2019-08-07 09:27:43 PDT
Created attachment 375703 [details] Patch
WebKit Commit Bot
Comment 4 2019-08-07 10:21:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 375703 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-08-07 10:22:45 PDT
Comment on attachment 375703 [details] Patch Clearing flags on attachment: 375703 Committed r248372: <https://trac.webkit.org/changeset/248372>
WebKit Commit Bot
Comment 6 2019-08-07 10:22:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-07 10:23:26 PDT
<rdar://problem/54039018>
Note You need to log in before you can comment on or make changes to this bug.