Bug 200505

Summary: Add more threading assertions to ITP code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2019-08-07 08:51:43 PDT
Add more threading assertions to ITP code to help cache bugs and protect against future bad usage.
Comment 1 Chris Dumez 2019-08-07 08:52:28 PDT
Created attachment 375700 [details]
Patch
Comment 2 Brent Fulgham 2019-08-07 09:23:25 PDT
Comment on attachment 375700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375700&action=review

r=mews.

> Source/WebKit/ChangeLog:8
> +        Add more threading assertions to ITP code to help cache bugs and protect against future bad usage.

cache bugs? or catch bugs?
Comment 3 Chris Dumez 2019-08-07 09:27:43 PDT
Created attachment 375703 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-07 10:21:59 PDT
The commit-queue encountered the following flaky tests while processing attachment 375703 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-08-07 10:22:45 PDT
Comment on attachment 375703 [details]
Patch

Clearing flags on attachment: 375703

Committed r248372: <https://trac.webkit.org/changeset/248372>
Comment 6 WebKit Commit Bot 2019-08-07 10:22:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-07 10:23:26 PDT
<rdar://problem/54039018>