Bug 200490

Summary: Extra space inserted at start of line when inserting a newline in Mail compose
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, koivisto, rniwa, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing none

Wenson Hsieh
Reported 2019-08-06 16:57:00 PDT
<rdar://problem/53501354>
Attachments
Patch (8.96 KB, patch)
2019-08-06 17:57 PDT, Wenson Hsieh 		koivisto: review+
DetailsFormatted DiffDiff
Patch for landing (8.86 KB, patch)
2019-08-07 08:16 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-08-06 17:57:32 PDT
Created attachment 375673 [details] Patch
Wenson Hsieh
Comment 2 2019-08-06 19:25:02 PDT
> perl Tools/Scripts/svn-apply --force .buildbot-diff > in dir C:\Buildbot\WinCairo-EWS\build (timeout 300 secs) > ... > patch: **** Can't create file C:\Users\ContainerAdministrator\AppData\Local\Temp/ppz02368 : File exists > fatal: pathspec 'LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html' did not match any files > Failed to git add LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html. at Tools/Scripts/svn-apply line 470. 🤷🏻‍♂️
Antti Koivisto
Comment 3 2019-08-07 07:55:00 PDT
Comment on attachment 375673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review > Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53 > +bool containsOffset(const RenderObject&, const Layout&, unsigned); This declaration has different signature than the definition below (no OffsetType). > Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122 > + bool isCaretOffsetType = offsetType == OffsetType::CaretOffset; This helper bool doesn't seem necessary.
Wenson Hsieh
Comment 4 2019-08-07 07:58:17 PDT
Comment on attachment 375673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review >> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53 >> +bool containsOffset(const RenderObject&, const Layout&, unsigned); > > This declaration has different signature than the definition below (no OffsetType). Oops, fixed! >> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122 >> + bool isCaretOffsetType = offsetType == OffsetType::CaretOffset; > > This helper bool doesn't seem necessary. Sounds good! Removed this local variable.
Wenson Hsieh
Comment 5 2019-08-07 08:16:05 PDT
Created attachment 375698 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-08-07 09:23:58 PDT
Comment on attachment 375698 [details] Patch for landing Clearing flags on attachment: 375698 Committed r248368: <https://trac.webkit.org/changeset/248368>
Note You need to log in before you can comment on or make changes to this bug.