Bug 200490

Summary:

Extra space inserted at start of line when inserting a newline in Mail compose

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, koivisto, rniwa, thorton, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+
Patch for landing	none

Description Wenson Hsieh 2019-08-06 16:57:00 PDT

<rdar://problem/53501354>

Comment 1 Wenson Hsieh 2019-08-06 17:57:32 PDT

Created attachment 375673 [details]
Patch

Comment 2 Wenson Hsieh 2019-08-06 19:25:02 PDT

> perl Tools/Scripts/svn-apply --force .buildbot-diff
>  in dir C:\Buildbot\WinCairo-EWS\build (timeout 300 secs)
> ...
> patch: **** Can't create file C:\Users\ContainerAdministrator\AppData\Local\Temp/ppz02368 : File exists
> fatal: pathspec 'LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html' did not match any files
> Failed to git add LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html. at Tools/Scripts/svn-apply line 470.

🤷🏻‍♂️

Comment 3 Antti Koivisto 2019-08-07 07:55:00 PDT

Comment on attachment 375673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review

> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53
> +bool containsOffset(const RenderObject&, const Layout&, unsigned);

This declaration has different signature than the definition below (no OffsetType).

> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122
> +    bool isCaretOffsetType = offsetType == OffsetType::CaretOffset;

This helper bool doesn't seem necessary.

Comment 4 Wenson Hsieh 2019-08-07 07:58:17 PDT

Comment on attachment 375673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review

>> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53
>> +bool containsOffset(const RenderObject&, const Layout&, unsigned);
> 
> This declaration has different signature than the definition below (no OffsetType).

Oops, fixed!

>> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122
>> +    bool isCaretOffsetType = offsetType == OffsetType::CaretOffset;
> 
> This helper bool doesn't seem necessary.

Sounds good! Removed this local variable.

Comment 5 Wenson Hsieh 2019-08-07 08:16:05 PDT

Created attachment 375698 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2019-08-07 09:23:58 PDT

Comment on attachment 375698 [details]
Patch for landing

Clearing flags on attachment: 375698

Committed r248368: <https://trac.webkit.org/changeset/248368>