Bug 200481

Summary: Web Inspector: RTL: content of Variables section should always be LTR
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
hi: review+
[Image] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2019-08-06 15:42:43 PDT
Created attachment 375655 [details] [Image] Bug Variables section (Elements tab, Computed panel) contains CSS. CSS is LTR, so this section should be LTR.
Attachments
[Image] Bug (141.09 KB, image/png)
2019-08-06 15:42 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.46 KB, patch)
2019-08-06 15:49 PDT, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
[Image] With patch applied (134.00 KB, image/png)
2019-08-07 11:19 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.62 KB, patch)
2019-08-07 13:55 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-08-06 15:49:12 PDT
Created attachment 375657 [details] Patch
Nikita Vasilyev
Comment 2 2019-08-07 11:19:26 PDT
Created attachment 375718 [details] [Image] With patch applied
Devin Rousso
Comment 3 2019-08-07 13:51:28 PDT
Comment on attachment 375657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375657&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:124 > + variablesRow.element.dir = "ltr"; Can we put this on `this._variablesTextEditor.element` instead? That way, its more "contained" to only what needs to be LTR.
Nikita Vasilyev
Comment 4 2019-08-07 13:55:42 PDT
Created attachment 375748 [details] Patch
WebKit Commit Bot
Comment 5 2019-08-07 14:32:53 PDT
Comment on attachment 375748 [details] Patch Clearing flags on attachment: 375748 Committed r248390: <https://trac.webkit.org/changeset/248390>
WebKit Commit Bot
Comment 6 2019-08-07 14:32:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-07 14:33:21 PDT
<rdar://problem/54051047>
Note You need to log in before you can comment on or make changes to this bug.