Bug 200471

Summary: [WHLSL] Metal code generation unnecessarily does string copies by passing partial results as Strings
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, mmaxfield, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200474
Attachments:
Description Flags
Patch saam: review+

Sam Weinig
Reported 2019-08-06 10:37:42 PDT
WHLSL Metal code generation unnecessarily does string copies by passing partial results as Strings
Attachments
Patch (68.74 KB, patch)
2019-08-06 10:47 PDT, Sam Weinig 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2019-08-06 10:47:42 PDT
Created attachment 375632 [details] Patch
Saam Barati
Comment 2 2019-08-06 10:58:57 PDT
Comment on attachment 375632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375632&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:93 > + // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String void => avoid Maybe also worth filing a bug? > Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:405 > + // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String ditto
Sam Weinig
Comment 3 2019-08-06 11:47:00 PDT
(In reply to Saam Barati from comment #2) > Comment on attachment 375632 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375632&action=review > > > Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:93 > > + // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String > > void => avoid > > Maybe also worth filing a bug? https://bugs.webkit.org/show_bug.cgi?id=200474
Sam Weinig
Comment 4 2019-08-06 12:04:02 PDT
Committed r248307: <https://trac.webkit.org/changeset/248307>
Radar WebKit Bug Importer
Comment 5 2019-08-06 12:04:20 PDT
<rdar://problem/53997291>
Note You need to log in before you can comment on or make changes to this bug.