Bug 200467

Summary: Add release assert against InvalidationRuleSet mutation during invalidation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2019-08-06 05:18:33 PDT
There have been some rare nullptr crashes here.
Attachments
patch (4.55 KB, patch)
2019-08-06 05:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-08-06 05:26:25 PDT
Created attachment 375619 [details] patch
Chris Dumez
Comment 2 2019-08-06 08:11:52 PDT
Comment on attachment 375619 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375619&action=review > Source/WebCore/css/DocumentRuleSets.h:79 > + static bool s_isInvalidatingStyleWithRuleSets; I am unclear why it is OK for this to be a static. I do not think DocumentRuleSets are process-global, are they?
Antti Koivisto
Comment 3 2019-08-06 08:22:22 PDT
> I am unclear why it is OK for this to be a static. I do not think > DocumentRuleSets are process-global, are they? Invalidation affecting some other random DocumentRuleSets would be equally bad, this covers that case too.
Chris Dumez
Comment 4 2019-08-06 08:27:49 PDT
Comment on attachment 375619 [details] patch Ok then.
WebKit Commit Bot
Comment 5 2019-08-06 09:18:11 PDT
Comment on attachment 375619 [details] patch Clearing flags on attachment: 375619 Committed r248297: <https://trac.webkit.org/changeset/248297>
WebKit Commit Bot
Comment 6 2019-08-06 09:18:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-06 09:19:24 PDT
<rdar://problem/53988679>
Note You need to log in before you can comment on or make changes to this bug.