| Summary: | Add release assert against InvalidationRuleSet mutation during invalidation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2019-08-06 05:18:33 PDT
Created attachment 375619 [details]
patch
Comment on attachment 375619 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375619&action=review > Source/WebCore/css/DocumentRuleSets.h:79 > + static bool s_isInvalidatingStyleWithRuleSets; I am unclear why it is OK for this to be a static. I do not think DocumentRuleSets are process-global, are they? > I am unclear why it is OK for this to be a static. I do not think
> DocumentRuleSets are process-global, are they?
Invalidation affecting some other random DocumentRuleSets would be equally bad, this covers that case too.
Comment on attachment 375619 [details]
patch
Ok then.
Comment on attachment 375619 [details] patch Clearing flags on attachment: 375619 Committed r248297: <https://trac.webkit.org/changeset/248297> All reviewed patches have been landed. Closing bug. |