Bug 200466

Summary: REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ggaren, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Antti Koivisto 2019-08-06 03:33:59 PDT
The page calls preventDefault() for a mouse event generated by site specific quirk.
Comment 1 Antti Koivisto 2019-08-06 03:42:06 PDT
<rdar://problem/52571754>
Comment 2 Antti Koivisto 2019-08-06 03:43:41 PDT
Created attachment 375616 [details]
patch
Comment 3 WebKit Commit Bot 2019-08-06 08:37:34 PDT
Comment on attachment 375616 [details]
patch

Clearing flags on attachment: 375616

Committed r248295: <https://trac.webkit.org/changeset/248295>
Comment 4 WebKit Commit Bot 2019-08-06 08:37:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 zalan 2019-08-06 11:07:33 PDT
Comment on attachment 375616 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review

> Source/WebCore/page/Quirks.cpp:303
> +        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.

SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version.
Comment 6 Geoffrey Garen 2019-08-06 11:13:16 PDT
Comment on attachment 375616 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review

>> Source/WebCore/page/Quirks.cpp:303
>> +        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
> 
> SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version.

My understanding is that we only set WebsiteSimulatedMouseEventsDispatchPolicy::Allow when in desktop mode. (See WebPageProxy::effectiveContentModeAfterAdjustingPolicies.) I wonder how we ended up in desktop mode at all on an m. site.
Comment 7 Antti Koivisto 2019-08-06 13:04:02 PDT
If you go to m.naver.com (or any URL) on iPad it will be loaded by default in desktop mode. Or do we have heuristics somewhere that should figure out it is a mobile site?
Comment 8 Antti Koivisto 2019-08-06 13:13:11 PDT
If you go to the top naver.com you get redirected to the m. subdomain only in mobile mode. However there is no automatic redirect back to the main site in desktop mode. If you for example have an existing bookmark it will probably point to the m. site.
Comment 9 Geoffrey Garen 2019-08-06 14:45:40 PDT
(In reply to Antti Koivisto from comment #7)
> If you go to m.naver.com (or any URL) on iPad it will be loaded by default
> in desktop mode. Or do we have heuristics somewhere that should figure out
> it is a mobile site?

Always desktop mode, modulo a short list of exceptions.
Comment 10 Geoffrey Garen 2019-08-06 14:46:00 PDT
(In reply to Antti Koivisto from comment #8)
> If you go to the top naver.com you get redirected to the m. subdomain only
> in mobile mode. However there is no automatic redirect back to the main site
> in desktop mode. If you for example have an existing bookmark it will
> probably point to the m. site.

Makes sense.