Bug 200429

Summary: Mangled WHLSL names don't need to allocate Strings
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, roninmike8, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2019-08-04 13:14:58 PDT
Mangled WHLSL names don't need to allocate Strings
Attachments
Patch (73.77 KB, patch)
2019-08-04 13:23 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (74.13 KB, patch)
2019-08-04 13:49 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2019-08-04 13:23:01 PDT
Created attachment 375507 [details] Patch
Sam Weinig
Comment 2 2019-08-04 13:49:07 PDT
Created attachment 375508 [details] Patch
Saam Barati
Comment 3 2019-08-04 18:15:36 PDT
Comment on attachment 375508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375508&action=review r=me Just curious: Did you measure any compile time speedup? I like to flip the “dumpPhaseTimes” Boolean to true in WHLSLPrepare and run some shaders to measure compile time changes. I’ll email you the web page I use. > Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:159 > + return string.is8Bit(); Why not an assert?
WebKit Commit Bot
Comment 4 2019-08-04 20:26:40 PDT
Comment on attachment 375508 [details] Patch Clearing flags on attachment: 375508 Committed r248266: <https://trac.webkit.org/changeset/248266>
WebKit Commit Bot
Comment 5 2019-08-04 20:26:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-04 20:27:17 PDT
<rdar://problem/53927415>
Mike Ronin
Comment 7 2019-08-04 22:55:02 PDT
Thanks for the bug and the appropriate fix. Webroot Geek Squad provides the users of Secureanywhere with the best technical support and assistance for their queries and problems after they Install Webroot from: https://secureanywherewebroot.com/
Note You need to log in before you can comment on or make changes to this bug.