Bug 200429

Summary: Mangled WHLSL names don't need to allocate Strings
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews, graouts, kondapallykalyan, roninmike8, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sam Weinig 2019-08-04 13:14:58 PDT
Mangled WHLSL names don't need to allocate Strings
Comment 1 Sam Weinig 2019-08-04 13:23:01 PDT
Created attachment 375507 [details]
Patch
Comment 2 Sam Weinig 2019-08-04 13:49:07 PDT
Created attachment 375508 [details]
Patch
Comment 3 Saam Barati 2019-08-04 18:15:36 PDT
Comment on attachment 375508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375508&action=review

r=me

Just curious: Did you measure any compile time speedup? I like to flip the “dumpPhaseTimes” Boolean to true in WHLSLPrepare and run some shaders to measure compile time changes. I’ll email you the web page I use.

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:159
> +                return string.is8Bit();

Why not an assert?
Comment 4 WebKit Commit Bot 2019-08-04 20:26:40 PDT
Comment on attachment 375508 [details]
Patch

Clearing flags on attachment: 375508

Committed r248266: <https://trac.webkit.org/changeset/248266>
Comment 5 WebKit Commit Bot 2019-08-04 20:26:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-04 20:27:17 PDT
<rdar://problem/53927415>
Comment 7 Mike Ronin 2019-08-04 22:55:02 PDT
Thanks for the bug and the appropriate fix.
Webroot Geek Squad provides the users of Secureanywhere with the best technical support and assistance for their queries and problems after they Install Webroot from: https://secureanywherewebroot.com/