Bug 200404

Summary:

run-webkit-tests asserts when the iPhone XR simulator is running

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Dean Jackson

Reported 2019-08-02 14:05:42 PDT

run-webkit-tests asserts when the iPhone XR simulator is running

Attachments
Patch (3.28 KB, patch) 2019-08-02 14:10 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (24.17 KB, patch) 2019-08-02 15:41 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-08-02 14:06:18 PDT

<rdar://problem/53878739>

Dean Jackson

Comment 2 2019-08-02 14:07:14 PDT

UnicodeEncodeError raised: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128) Traceback (most recent call last): File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main run_details = run(port, options, args, stderr) File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in run run_details = manager.run(args) File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 187, in run for_device_type = 'for {} '.format(device_type) if device_type else '' File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/xcode/device_type.py", line 120, in __str__ hardware_type=' {}'.format(self.hardware_type) if self.hardware_type else '', UnicodeEncodeError: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128)

Radar WebKit Bug Importer

Comment 3 2019-08-02 14:07:27 PDT

<rdar://problem/53878791>

Dean Jackson

Comment 4 2019-08-02 14:10:09 PDT

Created attachment 375453 [details] Patch

Jonathan Bedard

Comment 5 2019-08-02 14:15:06 PDT

This change is correct, but probably not sufficient. Bet if we edited the output of Tools/Scripts/webkitpy/Xcode/simulated_device_unittest.py, we could get a complete fix.

Jonathan Bedard

Comment 6 2019-08-02 14:34:20 PDT

Comment on attachment 375453 [details] Patch Hold up...this breaks things for me locally in a surprising way....investigating.

Jonathan Bedard

Comment 7 2019-08-02 15:41:21 PDT

Created attachment 375462 [details] Patch

Jonathan Bedard

Comment 8 2019-08-05 09:12:03 PDT

Comment on attachment 375462 [details] Patch Talked to Russell, this fixed XR's for him. I think this is all we need, so I'm going to land it. I'll be keeping an eye out for this sort of thing, though, we do a bad job at handling unicode in webkitpy.

WebKit Commit Bot

Comment 9 2019-08-05 09:42:30 PDT

Comment on attachment 375462 [details] Patch Clearing flags on attachment: 375462 Committed r248270: <https://trac.webkit.org/changeset/248270>

WebKit Commit Bot

Comment 10 2019-08-05 09:42:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.