Summary: | results.webkit.org: Force update cache when timeline updated | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, webkit-bug-importer, zhifei_fang | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2019-08-01 14:42:30 PDT
Created attachment 375349 [details]
Patch
Comment on attachment 375349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375349&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:151 > + if (element.logicWidth != width || force) { I think if (force) will be enough here I will give a new patch about this change, we shouldn't force to redraw cache every time when the state change, this will impact the performance. Created attachment 375354 [details]
Patch
Comment on attachment 375354 [details]
Patch
Can we add the exporter hook?
Also, I'm going to mark my patch as obsolete, since I redrew on scroll too.
Created attachment 375357 [details]
Patch
(In reply to Jonathan Bedard from comment #5) > Comment on attachment 375354 [details] > Patch > > Can we add the exporter hook? > > Also, I'm going to mark my patch as obsolete, since I redrew on scroll too. Added. Created attachment 375366 [details]
Patch
Comment on attachment 375366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375366&action=review > Tools/ChangeLog:11 > + (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. I think you also need to mention the fact that you added the exporter bit. Created attachment 375376 [details]
Patch
Comment on attachment 375376 [details] Patch Clearing flags on attachment: 375376 Committed r248146: <https://trac.webkit.org/changeset/248146> All reviewed patches have been landed. Closing bug. |