Bug 200363

Summary: results.webkit.org: Force update cache when timeline updated
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jbedard: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2019-08-01 14:42:30 PDT
We need to force the cache to update when the timeline is updated, and we need an exporter to update the timeline.
Attachments
Patch (4.11 KB, patch)
2019-08-01 14:48 PDT, Jonathan Bedard 		jbedard: commit-queue-
DetailsFormatted DiffDiff
Patch (5.16 KB, patch)
2019-08-01 15:15 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (6.07 KB, patch)
2019-08-01 15:30 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (6.43 KB, patch)
2019-08-01 16:46 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (6.12 KB, patch)
2019-08-01 18:46 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-08-01 14:48:55 PDT
Created attachment 375349 [details] Patch
Zhifei Fang
Comment 2 2019-08-01 14:54:13 PDT
Comment on attachment 375349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375349&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:151 > + if (element.logicWidth != width || force) { I think if (force) will be enough here
Zhifei Fang
Comment 3 2019-08-01 15:05:12 PDT
I will give a new patch about this change, we shouldn't force to redraw cache every time when the state change, this will impact the performance.
Zhifei Fang
Comment 4 2019-08-01 15:15:17 PDT
Created attachment 375354 [details] Patch
Jonathan Bedard
Comment 5 2019-08-01 15:24:44 PDT
Comment on attachment 375354 [details] Patch Can we add the exporter hook? Also, I'm going to mark my patch as obsolete, since I redrew on scroll too.
Zhifei Fang
Comment 6 2019-08-01 15:30:25 PDT
Created attachment 375357 [details] Patch
Zhifei Fang
Comment 7 2019-08-01 15:30:44 PDT
(In reply to Jonathan Bedard from comment #5) > Comment on attachment 375354 [details] > Patch > > Can we add the exporter hook? > > Also, I'm going to mark my patch as obsolete, since I redrew on scroll too. Added.
Zhifei Fang
Comment 8 2019-08-01 16:46:47 PDT
Created attachment 375366 [details] Patch
Jonathan Bedard
Comment 9 2019-08-01 17:10:31 PDT
Comment on attachment 375366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375366&action=review > Tools/ChangeLog:11 > + (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. I think you also need to mention the fact that you added the exporter bit.
Zhifei Fang
Comment 10 2019-08-01 18:46:29 PDT
Created attachment 375376 [details] Patch
WebKit Commit Bot
Comment 11 2019-08-01 20:50:21 PDT
Comment on attachment 375376 [details] Patch Clearing flags on attachment: 375376 Committed r248146: <https://trac.webkit.org/changeset/248146>
WebKit Commit Bot
Comment 12 2019-08-01 20:50:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-08-01 20:51:16 PDT
<rdar://problem/53846931>
Note You need to log in before you can comment on or make changes to this bug.