Summary: | wxWebKit wxPy binary packager for Win | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ollivier <kevino> | ||||
Component: | WebKit wx | Assignee: | Kevin Ollivier <kevino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Wx | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Kevin Ollivier
2008-07-14 18:06:57 PDT
Created attachment 22276 [details]
patch to build a Win installer for wxWebKit binaries
Comment on attachment 22276 [details]
patch to build a Win installer for wxWebKit binaries
I think the license for the App would actually be a BSD or LGPL license judging by the code in WebKit.
retval = os.path.abspath(os.path.join(__file__,"..","..", "..", "WebKitBuild"))
WebKit style says there should be a space after each ,
Your svnrevision lookup should ideally be a function call so that it's easier to add Git-svn support later. Many WebKit hackers use git-svn these days.
Otherwise this looks fine. Since you're a committer, I trust you can fix these all w/o needing to upload another patch.
Thanks!
|