Bug 20035

Summary: [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()
Product: WebKit Reporter: Wouter Bolsterlee <uws+webkit>
Component: WebKitGTKAssignee: Wouter Bolsterlee <uws+webkit>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed fix
none
Updated patch eric: review+

Description Wouter Bolsterlee 2008-07-14 16:51:58 PDT 
Currently webkit_web_view_go_to_back_forward_item() always returns TRUE. There's a FIXME in the code to change this. Find attached a patch that changes this into a more suitable return value.

Note that the Objective-C docs at http://developer.apple.com/documentation/Cocoa/Reference/WebKit/Classes/WebView_Class/Reference/Reference.html#//apple_ref/occ/instm/WebView/goToBackForwardItem: seem to suggest this approach as well.
Comment 1 Wouter Bolsterlee 2008-07-14 16:54:55 PDT 
Created attachment 22274 [details]
Proposed fix
Comment 2 Wouter Bolsterlee 2008-07-14 17:06:07 PDT 
02:03:33 < bdash> uws: https://bugs.webkit.org/attachment.cgi?id=22274&action=prettypatch -- the 
                  declaration and assignment should be on the same line, and the variable name 
                  should match our coding style guidelines
Comment 3 Wouter Bolsterlee 2008-07-14 17:12:42 PDT 
Created attachment 22275 [details]
Updated patch
Comment 4 Eric Seidel (no email) 2008-08-01 17:00:43 PDT 
Comment on attachment 22275 [details]
Updated patch

Looks fine.
Comment 5 Jan Alonzo 2008-08-01 22:20:24 PDT 
landed in r35522