Bug 200347

Summary:

results.webkit.org: Collision detection for dots is off by 2 * dotMargin

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer, zhifei_fang

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jbedard: commit-queue-
Patch	none

Description Jonathan Bedard 2019-08-01 09:28:11 PDT

Messing around with the canvas timeline, our collision detection isn't quite right. It's definitely the dotMargin.

Comment 1 Jonathan Bedard 2019-08-01 09:29:46 PDT

Created attachment 375315 [details]
Patch

Comment 2 Jonathan Bedard 2019-08-01 09:31:24 PDT

This patch 'fixes' the problem, but it's definitely the wrong way to do it. It feels like the actual x value of the dots is wrong.

Comment 3 Zhifei Fang 2019-08-01 10:17:22 PDT

Created attachment 375321 [details]
Patch

Comment 4 WebKit Commit Bot 2019-08-01 12:43:09 PDT

Comment on attachment 375321 [details]
Patch

Clearing flags on attachment: 375321

Committed r248117: <https://trac.webkit.org/changeset/248117>

Comment 5 WebKit Commit Bot 2019-08-01 12:43:10 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-08-01 12:44:17 PDT

<rdar://problem/53827885>