Bug 200347

Summary: results.webkit.org: Collision detection for dots is off by 2 * dotMargin
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jbedard: commit-queue-
Patch none

Jonathan Bedard
Reported 2019-08-01 09:28:11 PDT
Messing around with the canvas timeline, our collision detection isn't quite right. It's definitely the dotMargin.
Attachments
Patch (1.60 KB, patch)
2019-08-01 09:29 PDT, Jonathan Bedard 		jbedard: commit-queue-
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2019-08-01 10:17 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-08-01 09:29:46 PDT
Created attachment 375315 [details] Patch
Jonathan Bedard
Comment 2 2019-08-01 09:31:24 PDT
This patch 'fixes' the problem, but it's definitely the wrong way to do it. It feels like the actual x value of the dots is wrong.
Zhifei Fang
Comment 3 2019-08-01 10:17:22 PDT
Created attachment 375321 [details] Patch
WebKit Commit Bot
Comment 4 2019-08-01 12:43:09 PDT
Comment on attachment 375321 [details] Patch Clearing flags on attachment: 375321 Committed r248117: <https://trac.webkit.org/changeset/248117>
WebKit Commit Bot
Comment 5 2019-08-01 12:43:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-01 12:44:17 PDT
<rdar://problem/53827885>
Note You need to log in before you can comment on or make changes to this bug.