Bug 200323

Summary: Rename DOMJIT safe/unsafeFunction to functionWithTypeChecks and functionWithoutTypeChecks.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, fpizlo, ggaren, justin_michaud, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200292    
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2019-07-31 16:19:40 PDT
...
Attachments
proposed patch. (27.57 KB, patch)
2019-07-31 16:38 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-07-31 16:38:18 PDT
Created attachment 375267 [details] proposed patch.
Yusuke Suzuki
Comment 2 2019-07-31 16:44:21 PDT
Comment on attachment 375267 [details] proposed patch. r=me
Geoffrey Garen
Comment 3 2019-07-31 20:29:37 PDT
Comment on attachment 375267 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=375267&action=review > Source/JavaScriptCore/domjit/DOMJITSignature.h:40 > +using FunctionWithoutTypeCheck = void (*)(); I think I would call this CFunctionPointer. This type can point to any C function.
Mark Lam
Comment 4 2019-08-01 10:07:44 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 375267 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375267&action=review > > > Source/JavaScriptCore/domjit/DOMJITSignature.h:40 > > +using FunctionWithoutTypeCheck = void (*)(); > > I think I would call this CFunctionPointer. This type can point to any C > function. I'm going to land this as is for now. We'll probably change this again in https://bugs.webkit.org/show_bug.cgi?id=200292 after we find a better expression of the type.
Mark Lam
Comment 5 2019-08-01 10:14:42 PDT
Thanks for the reviews. Landed in r248105: <http://trac.webkit.org/r248105>.
Radar WebKit Bug Importer
Comment 6 2019-08-01 10:15:34 PDT
<rdar://problem/53820228>
Note You need to log in before you can comment on or make changes to this bug.