Bug 200309

Summary: [ContentChangeObserver] twitch.tv video controls do not always respond to taps in fullscreen
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2019-07-31 11:45:53 PDT
<rdar://problem/52964977>
Attachments
Patch (7.37 KB, patch)
2019-07-31 11:55 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.30 KB, patch)
2019-07-31 13:02 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2019-07-31 14:05 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-07-31 11:55:55 PDT
Created attachment 375232 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-07-31 12:44:05 PDT
Comment on attachment 375232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375232&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:108 > + if (auto* activeFullscreenElement = fullscreenElement(node.document())) > + return !node.isDescendantOf(*activeFullscreenElement); This doesn't handle the case of a subframe inside a fullscreen element.
alan
Comment 3 2019-07-31 13:02:25 PDT
Created attachment 375239 [details] Patch
alan
Comment 4 2019-07-31 14:05:43 PDT
Created attachment 375241 [details] Patch
WebKit Commit Bot
Comment 5 2019-07-31 16:01:48 PDT
Comment on attachment 375241 [details] Patch Clearing flags on attachment: 375241 Committed r248080: <https://trac.webkit.org/changeset/248080>
WebKit Commit Bot
Comment 6 2019-07-31 16:01:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.