Bug 200280

Summary:

Web Inspector: Console: all navigation items should be shown in the split console

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2019-07-30 13:30:17 PDT

Right now, only the message source scope bar, GC, and clear buttons are shown.  Since the Console's "Emulate User Gesture" (for example) has a global effect, it should be shown everywhere it could have an effect.

Comment 1 Devin Rousso 2019-07-30 13:59:14 PDT

Created attachment 375173 [details]
Patch

Comment 2 Joseph Pecoraro 2019-08-02 13:09:37 PDT

Comment on attachment 375173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375173&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:44
> +        this._inputField.placeholder = " "; // This is necessary for :placeholder-shown.

Interesting!

Comment 3 WebKit Commit Bot 2019-08-02 14:07:13 PDT

Comment on attachment 375173 [details]
Patch

Clearing flags on attachment: 375173

Committed r248180: <https://trac.webkit.org/changeset/248180>

Comment 4 WebKit Commit Bot 2019-08-02 14:07:15 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-08-02 14:08:20 PDT

<rdar://problem/53878871>