Bug 200258

Summary: imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html is a flakey failure, WebAssembly.Global is not implemented
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, saam, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Truitt Savell
Reported 2019-07-29 16:52:54 PDT
It looks like the imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html added in https://trac.webkit.org/changeset/247457/webkit is flaky on Mac Debug. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fwasm%2Fjsapi%2Finterface.any.worker.html Diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-actual.txt @@ -1,5 +1,3 @@ -CONSOLE MESSAGE: line 1774: TypeError: null is not an object (evaluating 'this.message_target.removeEventListener') -CONSOLE MESSAGE: line 154: TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype') Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype')
Attachments
Patch (1.63 KB, patch)
2019-12-04 00:12 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-29 16:53:27 PDT
<rdar://problem/53686304>
Yusuke Suzuki
Comment 2 2019-07-29 18:51:48 PDT
This is imported from wpt, and the error related to `WebAssembly.Global` thing is expected since this is not implemented yet. We can mark it as flaky. When `WebAssembly.Global` is implemented, we can make it PASS.
Truitt Savell
Comment 3 2019-07-30 08:24:36 PDT
Marked test as flakey in https://trac.webkit.org/changeset/248005/webkit
Alexey Proskuryakov
Comment 4 2019-07-30 15:28:38 PDT
Curious why an unimplemented feature causes flaky failures, not 100% failures. Is this test racy in some way?
Yusuke Suzuki
Comment 5 2019-12-04 00:06:18 PST
Let's unmark it since I implemented WebAssembly.Global.
Yusuke Suzuki
Comment 6 2019-12-04 00:12:30 PST
Created attachment 384792 [details] Patch
WebKit Commit Bot
Comment 7 2019-12-04 12:28:14 PST
Comment on attachment 384792 [details] Patch Clearing flags on attachment: 384792 Committed r253119: <https://trac.webkit.org/changeset/253119>
WebKit Commit Bot
Comment 8 2019-12-04 12:28:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.