Bug 200172

Summary: results.webkit.org: Use canvas for timeline
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-07-26 12:01:00 PDT
Asking the browser to render large timelines is very slow. We have a canvas implementation of the timeline that we should use instead.
Attachments
Patch (50.25 KB, patch)
2019-08-01 17:41 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (50.21 KB, patch)
2019-08-02 11:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (50.29 KB, patch)
2019-08-02 14:13 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (50.29 KB, patch)
2019-08-05 15:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (53.79 KB, patch)
2019-08-06 11:54 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (54.51 KB, patch)
2019-08-07 17:15 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.57 KB, patch)
2019-08-08 10:11 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-08-01 17:41:59 PDT
Created attachment 375371 [details] Patch
Jonathan Bedard
Comment 2 2019-08-02 11:51:52 PDT
Created attachment 375439 [details] Patch
Jonathan Bedard
Comment 3 2019-08-02 14:13:11 PDT
Created attachment 375454 [details] Patch
Jonathan Bedard
Comment 4 2019-08-05 15:58:19 PDT
Created attachment 375574 [details] Patch
Jonathan Bedard
Comment 5 2019-08-06 11:54:18 PDT
Created attachment 375638 [details] Patch
Zhifei Fang
Comment 6 2019-08-07 12:29:37 PDT
Comment on attachment 375638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375638&action=review > Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:368 > } Since now the element's children are multiple canvas, using element.innerHTML may cause some memory can not be gc, please use DOM.inject everywhere which will clean all the ref's reference, so that it can be gc finally. > Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:555 > + // FIXME: We should do something sane here, but we probably need another endpoint I guess we will need a popover ? > Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html:66 > this.children = {}; Same thing around here.
Zhifei Fang
Comment 7 2019-08-07 12:29:57 PDT
unofficially r=me
Jonathan Bedard
Comment 8 2019-08-07 17:15:33 PDT
Created attachment 375769 [details] Patch
Aakash Jain
Comment 9 2019-08-08 08:15:49 PDT
Comment on attachment 375769 [details] Patch rs=me
Jonathan Bedard
Comment 10 2019-08-08 10:11:44 PDT
Created attachment 375811 [details] Patch for landing
WebKit Commit Bot
Comment 11 2019-08-08 10:53:58 PDT
Comment on attachment 375811 [details] Patch for landing Clearing flags on attachment: 375811 Committed r248425: <https://trac.webkit.org/changeset/248425>
WebKit Commit Bot
Comment 12 2019-08-08 10:54:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-08-08 10:54:16 PDT
<rdar://problem/54086870>
Note You need to log in before you can comment on or make changes to this bug.