Bug 200127

Summary: results.webkit.org: Color should be the worst result, count should include all results
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2019-07-25 09:24:57 PDT
Talking to bot watchers, it seems that the fact that the count included only the count of the worst failures as opposed to a count of all failures is a source of confusion. Make it so that the count of failures includes all failures, regardless of type. For example, a test run with 30 crashes, 4 timeouts and 13 ImageDiff failures would be assigned the color purple, but have a count of 47. The current behavior would cause such a run to be assigned the color purple and have a count of 30.
Attachments
Patch (2.03 KB, patch)
2019-07-25 09:28 PDT, Jonathan Bedard
no flags
Patch (2.07 KB, patch)
2019-07-25 17:24 PDT, Jonathan Bedard
no flags
Patch (1.42 KB, patch)
2019-07-26 08:22 PDT, Jonathan Bedard
no flags
Jonathan Bedard
Comment 1 2019-07-25 09:28:57 PDT
Ryan Haddad
Comment 2 2019-07-25 09:53:23 PDT
Agreed, this makes more sense.
Aakash Jain
Comment 3 2019-07-25 16:48:19 PDT
rs=me
Jonathan Bedard
Comment 4 2019-07-25 17:24:39 PDT
WebKit Commit Bot
Comment 5 2019-07-25 18:03:46 PDT
Comment on attachment 374927 [details] Patch Clearing flags on attachment: 374927 Committed r247850: <https://trac.webkit.org/changeset/247850>
WebKit Commit Bot
Comment 6 2019-07-25 18:03:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-25 18:04:16 PDT
Jonathan Bedard
Comment 8 2019-07-26 08:22:22 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 9 2019-07-26 08:22:23 PDT
WebKit Commit Bot
Comment 10 2019-07-26 09:08:21 PDT
Comment on attachment 374962 [details] Patch Clearing flags on attachment: 374962 Committed r247863: <https://trac.webkit.org/changeset/247863>
WebKit Commit Bot
Comment 11 2019-07-26 09:08:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.