|
Description
Devin Rousso
2019-07-24 20:43:31 PDT
Created attachment 374862 [details]
Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Created attachment 374866 [details]
Patch
Created attachment 374868 [details]
Patch
Comment on attachment 374868 [details] Patch Attachment 374868 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12807145 Number of test failures exceeded the failure limit. Created attachment 374870 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 374868 [details] Patch Attachment 374868 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12807120 Number of test failures exceeded the failure limit. Created attachment 374872 [details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 374874 [details]
Patch
Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12807389 Number of test failures exceeded the failure limit. Created attachment 374875 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12807471 Number of test failures exceeded the failure limit. Created attachment 374877 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 374874 [details] Patch Attachment 374874 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12807470 Number of test failures exceeded the failure limit. Created attachment 374880 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Archive of layout-test-results from ews101 for mac-highsierra<a href="http://thestorelocator.co.uk">...</a> Comment on attachment 374874 [details]
Patch
LGTM, but can't r+ until the tests are fixed.
(In reply to Brian Burg from comment #17) > LGTM, but can't r+ until the tests are fixed. The tests should be fixed once the blocking bug 200109 is fixed. Created attachment 375878 [details]
Patch
Comment on attachment 375878 [details] Patch Attachment 375878 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12882755 New failing tests: http/tests/websocket/tests/hybi/inspector/before-load.html http/tests/websocket/tests/hybi/inspector/resolveWebSocket.html Created attachment 375885 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375878 [details] Patch Attachment 375878 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12882809 New failing tests: http/tests/websocket/tests/hybi/inspector/resolveWebSocket.html http/tests/websocket/tests/hybi/inspector/before-load.html Created attachment 375887 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 376081 [details]
Patch
Created attachment 376083 [details]
Patch
Rebase
Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12899339 New failing tests: http/tests/inspector/network/har/har-basic.html inspector/runtime/change-execution-context-identifier.html Created attachment 376086 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12899385 New failing tests: http/tests/inspector/network/har/har-basic.html inspector/runtime/change-execution-context-identifier.html Created attachment 376091 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 376083 [details] Patch Attachment 376083 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12899498 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla See <https://webkit.org/b/200854> for explanation. |