Bug 200107

Summary: Avoid UI Process hangs when the WebContent process is showing JS prompts / alerts
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200126    
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review+, commit-queue: commit-queue-

Chris Dumez
Reported 2019-07-24 19:37:53 PDT
Avoid UI Process hangs when the WebContent process is showing JS prompts / alerts.
Attachments
Patch (29.21 KB, patch)
2019-07-24 19:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (29.20 KB, patch)
2019-07-24 20:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (29.20 KB, patch)
2019-07-24 20:33 PDT, Chris Dumez 		ggaren: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-07-24 19:38:09 PDT
<rdar://problem/53034592>
Chris Dumez
Comment 2 2019-07-24 19:55:55 PDT
Created attachment 374853 [details] Patch
EWS Watchlist
Comment 3 2019-07-24 19:59:30 PDT
Attachment 374853 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:384: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2019-07-24 20:12:17 PDT
Created attachment 374857 [details] Patch
EWS Watchlist
Comment 5 2019-07-24 20:13:52 PDT
Attachment 374857 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:384: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 6 2019-07-24 20:33:41 PDT
Created attachment 374859 [details] Patch
EWS Watchlist
Comment 7 2019-07-24 20:36:12 PDT
Attachment 374859 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:384: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 8 2019-07-24 21:39:41 PDT
Comment on attachment 374859 [details] Patch r=me
WebKit Commit Bot
Comment 9 2019-07-24 21:52:58 PDT
Comment on attachment 374859 [details] Patch Rejecting attachment 374859 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 374859, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12807209
Chris Dumez
Comment 10 2019-07-25 08:42:18 PDT
Committed r247822: <https://trac.webkit.org/changeset/247822>
Note You need to log in before you can comment on or make changes to this bug.