Bug 200104

Summary:

Web Inspector: allow comments in protocol JSON

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, sacolo9459, tzagallo, vohaw37044, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2019-07-24 18:59:13 PDT

Attachments
Patch (54.89 KB, patch) 2019-07-24 19:00 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (39.51 KB, patch) 2019-08-06 13:49 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-07-24 19:00:50 PDT

Created attachment 374844 [details] Patch

EWS Watchlist

Comment 2 2019-07-24 19:02:52 PDT Comment hidden (obsolete)

Attachment 374844 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/tests/generic/should-strip-comments.json:2: Expecting property name enclosed in double quotes: line 2 column 5 (char 6) [json/syntax] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 3 2019-08-06 10:25:41 PDT

Comment on attachment 374844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374844&action=review > Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:471 > + Ref<JSON::Object> jsonResult = m_result.releaseNonNull(); Please rebaseline stale results in a separate commit. It doesn't need to be reviewed.

Blaze Burg

Comment 4 2019-08-06 10:25:55 PDT

r=me

Devin Rousso

Comment 5 2019-08-06 13:49:39 PDT

Created attachment 375650 [details] Patch

EWS Watchlist

Comment 6 2019-08-06 13:51:36 PDT Comment hidden (obsolete)

Attachment 375650 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/tests/generic/should-strip-comments.json:2: Expecting property name enclosed in double quotes: line 2 column 5 (char 6) [json/syntax] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 7 2019-08-06 15:20:37 PDT

Comment on attachment 375650 [details] Patch Clearing flags on attachment: 375650 Committed r248320: <https://trac.webkit.org/changeset/248320>

WebKit Commit Bot

Comment 8 2019-08-06 15:20:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2019-08-06 15:21:23 PDT

<rdar://problem/54006498>

Devin Rousso

Comment 10 2019-08-07 10:26:04 PDT

Rebased inspector generator tests in r248374 <https://trac.webkit.org/r248374>.

Note You need to log in before you can comment on or make changes to this bug.