Summary: | [WHLSL] UnnamedType should be reference counted | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||
Component: | WebGPU | Assignee: | Saam Barati <saam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, thorton, tsavell, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Saam Barati
2019-07-24 15:16:48 PDT
Gonna work on this now Created attachment 374854 [details]
WIP
seems like 40% speedup on hello-cube.html Created attachment 374856 [details]
WIP
Created attachment 374918 [details]
WIP
Might be ready. Just want to read it over once.
Created attachment 374931 [details]
patch
Attachment 374931 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:958: 'getterReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'. [readability/naming/protected] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:971: 'anderReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'. [readability/naming/protected] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:988: 'threadAnderReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'. [readability/naming/protected] [4]
Total errors found: 3 in 47 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 374931 [details] patch Clearing flags on attachment: 374931 Committed r247878: <https://trac.webkit.org/changeset/247878> All reviewed patches have been landed. Closing bug. It looks like the changes in https://trac.webkit.org/changeset/247878/webkit caused testing in webgpu/ to exit early on Mojave Debug with crashes Build: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/3784 Results: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r247879%20(3784)/results.html I was able to reproduce this by just running the webgpu/ directory locally. (In reply to Truitt Savell from comment #10) > It looks like the changes in https://trac.webkit.org/changeset/247878/webkit > > caused testing in webgpu/ to exit early on Mojave Debug with crashes > > Build: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/ > builds/3784 > > Results: > https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/ > r247879%20(3784)/results.html > > I was able to reproduce this by just running the webgpu/ directory locally. Looking into it now I think I have the fix. Just waiting for my local build to finish (In reply to Saam Barati from comment #13) > fixed in: > https://trac.webkit.org/changeset/247887/webkit And a follow up in https://trac.webkit.org/changeset/247899/webkit |