Bug 200097

Summary: [WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Justin Fan
Reported 2019-07-24 14:53:37 PDT
[WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
Attachments
Patch (24.25 KB, patch)
2019-07-24 14:58 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (28.84 KB, patch)
2019-07-26 17:29 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-07-24 14:58:51 PDT
Created attachment 374814 [details] Patch
Justin Fan
Comment 2 2019-07-26 17:29:59 PDT
Created attachment 375003 [details] Patch
Myles C. Maxfield
Comment 3 2019-07-26 17:40:36 PDT
Comment on attachment 375003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375003&action=review > Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:-59 > - ArrayReferenceType(ArrayReferenceType&&) = default; Why?
Justin Fan
Comment 4 2019-07-26 17:44:07 PDT
Comment on attachment 375003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375003&action=review >> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:-59 >> - ArrayReferenceType(ArrayReferenceType&&) = default; > > Why? These classes were made RefCounted in a previous patch; remove their move ctors to fix build.
WebKit Commit Bot
Comment 5 2019-07-27 17:47:06 PDT
Comment on attachment 375003 [details] Patch Clearing flags on attachment: 375003 Committed r247892: <https://trac.webkit.org/changeset/247892>
WebKit Commit Bot
Comment 6 2019-07-27 17:47:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-07-27 17:48:16 PDT
<rdar://problem/53627743>
Note You need to log in before you can comment on or make changes to this bug.