Bug 200082 – [iOS] Add a test to ensure that a tap in editable content shows the callout bar if the selection did not change

• Component: HTML Editing
• Status: RESOLVED FIXED

[Wenson Hsieh]

...WebKit followup to <rdar://problem/53106460>.

[Wenson Hsieh]

Created attachment 377711 [details]
Patch

[Dean Jackson]

Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
> +    input = document.querySelector("input");

Dodgy way to declare a global :)

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");

I find it easier to parse if the arrow function has {}, but up to you.

[Wenson Hsieh]

Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
>> +    input = document.querySelector("input");
> 
> Dodgy way to declare a global :)

Ok — I’ll declare input outside, instead.

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
>> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");
> 
> I find it easier to parse if the arrow function has {}, but up to you.

Sure — I’ll add the {}.

[Wenson Hsieh]

Created attachment 377808 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 377808 [details]
Patch for landing

Clearing flags on attachment: 377808

Committed r249363: <https://trac.webkit.org/changeset/249363>