Bug 200082

Summary: [iOS] Add a test to ensure that a tap in editable content shows the callout bar if the selection did not change
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, bfulgham, commit-queue, dino, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch for landing none

Description Wenson Hsieh 2019-07-24 09:48:37 PDT 
...WebKit followup to <rdar://problem/53106460>.
Comment 1 Wenson Hsieh 2019-08-30 08:31:29 PDT 
Created attachment 377711 [details]
Patch
Comment 2 Dean Jackson 2019-08-31 15:11:54 PDT 
Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
> +    input = document.querySelector("input");

Dodgy way to declare a global :)

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");

I find it easier to parse if the arrow function has {}, but up to you.
Comment 3 Wenson Hsieh 2019-08-31 15:17:16 PDT 
Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
>> +    input = document.querySelector("input");
> 
> Dodgy way to declare a global :)

Ok — I’ll declare input outside, instead.

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
>> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");
> 
> I find it easier to parse if the arrow function has {}, but up to you.

Sure — I’ll add the {}.
Comment 4 Wenson Hsieh 2019-08-31 15:19:27 PDT 
Created attachment 377808 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-08-31 16:02:35 PDT 
Comment on attachment 377808 [details]
Patch for landing

Clearing flags on attachment: 377808

Committed r249363: <https://trac.webkit.org/changeset/249363>