Bug 20008

Summary: -webkit-transform should have good initial value
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Updated patch (includes test changes) hyatt: review+

Description Dean Jackson 2008-07-11 04:55:46 PDT 
See http://build.webkit.org/results/trunk-mac-ppc-release/13642/fast/css/computed-style-without-renderer-actual.txt
(ignore that the test says it is failing in that report)

-webkit-transform doesn't have a nice value when a parent of display none.
Comment 1 Simon Fraser (smfr) 2008-07-16 20:53:19 PDT 
It should return "none" in this case I think (as should an untransformed element).
Comment 2 Simon Fraser (smfr) 2008-07-16 21:19:53 PDT 
Created attachment 22329 [details]
Patch

This patch also fixes getComputedStyle() to return 'none' for elements with no tranform (previously, it would return an identity matrix).
Comment 3 Dean Jackson 2008-07-17 12:47:18 PDT 
Created attachment 22349 [details]
Updated patch (includes test changes)
Comment 4 Dave Hyatt 2008-07-18 12:17:23 PDT 
Comment on attachment 22349 [details]
Updated patch (includes test changes)

Remove the braces from

+    if (!renderer || renderer->style()->transform().isEmpty()) {
+        return CSSPrimitiveValue::createIdentifier(CSSValueNone);
+    }

r=me
Comment 5 Simon Fraser (smfr) 2008-07-18 15:11:29 PDT 
Fixed in r35239.