Bug 20008

Summary: -webkit-transform should have good initial value
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Updated patch (includes test changes) hyatt: review+

Dean Jackson
Reported 2008-07-11 04:55:46 PDT
See http://build.webkit.org/results/trunk-mac-ppc-release/13642/fast/css/computed-style-without-renderer-actual.txt (ignore that the test says it is failing in that report) -webkit-transform doesn't have a nice value when a parent of display none.
Attachments
Patch (1.51 KB, patch)
2008-07-16 21:19 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Updated patch (includes test changes) (2.81 KB, patch)
2008-07-17 12:47 PDT, Dean Jackson 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-07-16 20:53:19 PDT
It should return "none" in this case I think (as should an untransformed element).
Simon Fraser (smfr)
Comment 2 2008-07-16 21:19:53 PDT
Created attachment 22329 [details] Patch This patch also fixes getComputedStyle() to return 'none' for elements with no tranform (previously, it would return an identity matrix).
Dean Jackson
Comment 3 2008-07-17 12:47:18 PDT
Created attachment 22349 [details] Updated patch (includes test changes)
Dave Hyatt
Comment 4 2008-07-18 12:17:23 PDT
Comment on attachment 22349 [details] Updated patch (includes test changes) Remove the braces from + if (!renderer || renderer->style()->transform().isEmpty()) { + return CSSPrimitiveValue::createIdentifier(CSSValueNone); + } r=me
Simon Fraser (smfr)
Comment 5 2008-07-18 15:11:29 PDT
Fixed in r35239.
Note You need to log in before you can comment on or make changes to this bug.