Bug 200074

Summary: [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: CMakeAssignee: Fujii Hironori <fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, don.olmstead, mcatanzaro, ross.kirsling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=131177
https://bugs.webkit.org/show_bug.cgi?id=140049
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2019-07-24 00:09:10 PDT
[CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined" Although WebKitCompilerFlags.cmake adds "-Wl,--no-undefined" CMAKE_SHARED_LINKER_FLAGS, I found it isn't effective (Bug 199625 Comment 24). OptionsCommon.cmake has a typo. > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld -Wl,--disable-new-dtags") CMAKE_EXE_LINKER_FLAGS should be CMAKE_SHARED_LINKER_FLAGS.
Attachments
Patch (4.59 KB, patch)
2019-07-24 00:35 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-07-24 00:26:21 PDT
While working on this, I see an existing issue: > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeFiles/TestNetscapePlugIn.dir/PluginTest.cpp.o:PluginTest.cpp:function PluginTest::indicateTestFailure(): error: undefined reference to 'WTF::sleep(WTF::Seconds)'
Fujii Hironori
Comment 2 2019-07-24 00:35:04 PDT
Created attachment 374767 [details] Patch
Fujii Hironori
Comment 3 2019-07-24 00:43:44 PDT
These code was added in Bug 131177 and Bug 140049.
Fujii Hironori
Comment 4 2019-07-24 19:05:12 PDT
Comment on attachment 374767 [details] Patch Clearing flags on attachment: 374767 Committed r247810: <https://trac.webkit.org/changeset/247810>
Fujii Hironori
Comment 5 2019-07-24 19:05:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.