Bug 200074 - [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
Summary: [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-24 00:09 PDT by Fujii Hironori
Modified: 2019-07-24 19:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.59 KB, patch)
2019-07-24 00:35 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-24 00:09:10 PDT 
[CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"

Although WebKitCompilerFlags.cmake adds "-Wl,--no-undefined"
CMAKE_SHARED_LINKER_FLAGS, I found it isn't effective (Bug 199625 Comment 24).

OptionsCommon.cmake has a typo.

> set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld -Wl,--disable-new-dtags")

CMAKE_EXE_LINKER_FLAGS should be CMAKE_SHARED_LINKER_FLAGS.
Comment 1 Fujii Hironori 2019-07-24 00:26:21 PDT 
While working on this, I see an existing issue:

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeFiles/TestNetscapePlugIn.dir/PluginTest.cpp.o:PluginTest.cpp:function PluginTest::indicateTestFailure(): error: undefined reference to 'WTF::sleep(WTF::Seconds)'
Comment 2 Fujii Hironori 2019-07-24 00:35:04 PDT 
Created attachment 374767 [details]
Patch
Comment 3 Fujii Hironori 2019-07-24 00:43:44 PDT 
These code was added in Bug 131177 and Bug 140049.
Comment 4 Fujii Hironori 2019-07-24 19:05:12 PDT 
Comment on attachment 374767 [details]
Patch

Clearing flags on attachment: 374767

Committed r247810: <https://trac.webkit.org/changeset/247810>
Comment 5 Fujii Hironori 2019-07-24 19:05:16 PDT 
All reviewed patches have been landed.  Closing bug.