Bug 200067

Summary: Use 12 digits to show a git commit.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, jbedard, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

dewei_zhu
Reported 2019-07-23 17:43:33 PDT
Use 12 digits to show a git commit.
Attachments
Patch (2.08 KB, patch)
2019-07-23 17:46 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-07-23 17:46:28 PDT
Created attachment 374744 [details] Patch
dewei_zhu
Comment 2 2019-07-23 17:47:07 PDT
rdar://47048358
Jonathan Bedard
Comment 3 2019-07-24 08:11:41 PDT
I did the math for this a few months back, 8 is way to small and a collision is quite likely given 10's of thousands of commits. If I recall, 12 digits supports what is, in effect, around 100 years worth of WebKit commits at the current rate.
dewei_zhu
Comment 4 2019-07-24 10:10:53 PDT
Landed in r247770
Note You need to log in before you can comment on or make changes to this bug.