Bug 200050

Summary:

Deprecate WKContextGetWebsiteDataStore

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cdumez, cfleizach, cgarcia, dmazzoni, ews-watchlist, ggaren, jcraig, jdiggs, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

201480

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews115 for mac-highsierra	none
Archive of layout-test-results from ews210 for win-future	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2019-07-23 15:23:08 PDT

Deprecate WKContextGetWebsiteDataStore

Attachments
Patch (38.00 KB, patch) 2019-07-23 15:27 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.94 MB, application/zip) 2019-07-23 16:45 PDT, EWS Watchlist	no flags	Details
Patch (72.44 KB, patch) 2019-08-02 17:51 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (74.99 KB, patch) 2019-08-02 19:17 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (75.22 KB, patch) 2019-08-02 19:40 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (421.83 KB, application/zip) 2019-08-02 20:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (424.35 KB, application/zip) 2019-08-02 20:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews210 for win-future (12.98 MB, application/zip) 2019-08-02 20:57 PDT, EWS Watchlist	no flags	Details
Patch (89.98 KB, patch) 2019-09-06 13:14 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (86.21 KB, patch) 2019-09-06 21:02 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (99.18 KB, patch) 2019-09-06 23:02 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-07-23 15:27:00 PDT

Created attachment 374715 [details] Patch

Geoffrey Garen

Comment 2 2019-07-23 16:44:29 PDT

Comment on attachment 374715 [details] Patch If this API isn't used at all anymore on some group of OS's, wouldn't it be better to remove it completely (but optionally continue to compile it into the binary if needed for some backward-compatible case)?

EWS Watchlist

Comment 3 2019-07-23 16:45:19 PDT

Comment on attachment 374715 [details] Patch Attachment 374715 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12797239 New failing tests: http/tests/IndexedDB/storage-limit-2.https.html http/tests/IndexedDB/storage-limit-1.https.html

EWS Watchlist

Comment 4 2019-07-23 16:45:21 PDT

Created attachment 374734 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 5 2019-07-23 16:52:44 PDT

(In reply to Geoffrey Garen from comment #2) > Comment on attachment 374715 [details] > Patch > > If this API isn't used at all anymore on some group of OS's, wouldn't it be > better to remove it completely (but optionally continue to compile it into > the binary if needed for some backward-compatible case)? We still need it in the binary for open source webkit developers running their webkit with shipping safari.

Alex Christensen

Comment 6 2019-07-23 18:45:45 PDT

rdar://problem/53476085 needs to be fixed before this.

Alex Christensen

Comment 7 2019-08-02 17:51:08 PDT

Created attachment 375472 [details] Patch

EWS Watchlist

Comment 8 2019-08-02 17:53:18 PDT

Attachment 375472 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 9 2019-08-02 19:17:52 PDT

Created attachment 375475 [details] Patch

EWS Watchlist

Comment 10 2019-08-02 19:20:50 PDT

Attachment 375475 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 11 2019-08-02 19:40:53 PDT

Created attachment 375478 [details] Patch

EWS Watchlist

Comment 12 2019-08-02 19:42:58 PDT

Attachment 375478 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 13 2019-08-02 20:38:19 PDT

Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12855871 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 14 2019-08-02 20:38:21 PDT

Created attachment 375480 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 15 2019-08-02 20:47:41 PDT

Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12855855 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 16 2019-08-02 20:47:42 PDT

Created attachment 375481 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 17 2019-08-02 20:57:12 PDT

Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12855870 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 18 2019-08-02 20:57:14 PDT

Created attachment 375482 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Alex Christensen

Comment 19 2019-09-06 13:14:40 PDT

Created attachment 378224 [details] Patch

Alex Christensen

Comment 20 2019-09-06 21:02:47 PDT

Created attachment 378275 [details] Patch

Alex Christensen

Comment 21 2019-09-06 23:02:31 PDT

Created attachment 378280 [details] Patch

Alex Christensen

Comment 22 2019-09-07 09:04:14 PDT

http://trac.webkit.org/r249614