Bug 200040

Summary: Enable HAVE_APP_LINKS_WITH_ISENABLED for entire iOS family
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, eric.carlson, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Rollin
Reported 2019-07-23 12:11:33 PDT
This feature was enabled for just iOS, but should be enabled for tvOS and watchOS, too.
Attachments
Patch (1.40 KB, patch)
2019-07-23 12:35 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2019-07-23 13:27 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2019-07-23 13:29 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-23 12:13:04 PDT
<rdar://problem/53457670>
Keith Rollin
Comment 2 2019-07-23 12:35:26 PDT
Created attachment 374696 [details] Patch
Tim Horton
Comment 3 2019-07-23 12:41:01 PDT
Comment on attachment 374696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374696&action=review > Source/WTF/wtf/Platform.h:1562 > #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1 Do you want this one too?
Keith Rollin
Comment 4 2019-07-23 13:18:47 PDT
Eric, HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO got swept up in this change, enabling it for tvOS and watchOS. Should it actually be kept as iOS-only?
Keith Rollin
Comment 5 2019-07-23 13:24:36 PDT
Eric is on vacation. I'll side with caution and separate the flags.
Keith Rollin
Comment 6 2019-07-23 13:27:49 PDT
Created attachment 374703 [details] Patch
Keith Rollin
Comment 7 2019-07-23 13:29:26 PDT
Created attachment 374704 [details] Patch
WebKit Commit Bot
Comment 8 2019-07-23 16:01:32 PDT
Comment on attachment 374704 [details] Patch Clearing flags on attachment: 374704 Committed r247754: <https://trac.webkit.org/changeset/247754>
WebKit Commit Bot
Comment 9 2019-07-23 16:01:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.