Bug 200027

Summary:

Reorganize UIScriptController into platform-specific subclasses

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews214 for win-future	none
Patch	none
Patch	simon.fraser: review+

Tim Horton

Reported 2019-07-23 00:14:01 PDT

Reorganize UIScriptController into platform-specific subclasses

Attachments
Patch (111.34 KB, patch) 2019-07-23 00:14 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (176.74 KB, patch) 2019-07-25 23:48 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (165.03 KB, patch) 2019-07-25 23:55 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (167.38 KB, patch) 2019-07-26 00:46 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (169.50 KB, patch) 2019-07-26 00:54 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (169.67 KB, patch) 2019-07-26 00:58 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (171.17 KB, patch) 2019-07-26 23:42 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (171.31 KB, patch) 2019-07-27 00:46 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (170.16 KB, patch) 2019-07-27 02:02 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (171.39 KB, patch) 2019-07-27 02:34 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews214 for win-future (13.48 MB, application/zip) 2019-07-27 05:18 PDT, EWS Watchlist	no flags	Details
Patch (8.61 KB, patch) 2019-07-27 14:13 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (173.29 KB, patch) 2019-07-27 14:14 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2019-07-23 00:14:36 PDT

Created attachment 374678 [details] Patch

Tim Horton

Comment 2 2019-07-23 00:15:26 PDT

Not for review yet, haven't done any platform but mac

EWS Watchlist

Comment 3 2019-07-23 00:17:23 PDT Comment hidden (obsolete)

Attachment 374678 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:26: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.h:26: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:57: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.h:26: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 4 2019-07-25 23:48:44 PDT

Created attachment 374943 [details] Patch

EWS Watchlist

Comment 5 2019-07-25 23:50:07 PDT Comment hidden (obsolete)

Attachment 374943 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 6 2019-07-25 23:55:05 PDT

Created attachment 374945 [details] Patch

EWS Watchlist

Comment 7 2019-07-25 23:58:18 PDT Comment hidden (obsolete)

Attachment 374945 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 8 2019-07-26 00:46:55 PDT

Created attachment 374949 [details] Patch

EWS Watchlist

Comment 9 2019-07-26 00:48:08 PDT Comment hidden (obsolete)

Attachment 374949 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 10 2019-07-26 00:54:21 PDT

Created attachment 374950 [details] Patch

EWS Watchlist

Comment 11 2019-07-26 00:56:17 PDT Comment hidden (obsolete)

Attachment 374950 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 12 2019-07-26 00:58:34 PDT

Created attachment 374951 [details] Patch

EWS Watchlist

Comment 13 2019-07-26 01:01:29 PDT Comment hidden (obsolete)

Attachment 374951 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 14 2019-07-26 23:42:05 PDT

Created attachment 375017 [details] Patch

EWS Watchlist

Comment 15 2019-07-26 23:43:14 PDT Comment hidden (obsolete)

Attachment 375017 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 16 2019-07-27 00:46:04 PDT

Created attachment 375021 [details] Patch

EWS Watchlist

Comment 17 2019-07-27 00:47:38 PDT Comment hidden (obsolete)

Attachment 375021 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 18 2019-07-27 02:02:53 PDT

Created attachment 375023 [details] Patch

EWS Watchlist

Comment 19 2019-07-27 02:04:12 PDT Comment hidden (obsolete)

Attachment 375023 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 20 2019-07-27 02:34:17 PDT

Created attachment 375025 [details] Patch

EWS Watchlist

Comment 21 2019-07-27 02:37:20 PDT Comment hidden (obsolete)

Attachment 375025 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 22 2019-07-27 05:18:07 PDT Comment hidden (obsolete)

Comment on attachment 375025 [details] Patch Attachment 375025 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12821280 New failing tests: fast/events/autoscroll-when-input-is-offscreen.html fast/events/autoscroll-with-software-keyboard.html fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html fast/visual-viewport/client-rects-relative-to-layout-viewport.html pageoverlay/overlay-remove-reinsert-view.html

EWS Watchlist

Comment 23 2019-07-27 05:18:11 PDT Comment hidden (obsolete)

Created attachment 375029 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Tim Horton

Comment 24 2019-07-27 14:13:12 PDT

Created attachment 375033 [details] Patch

Tim Horton

Comment 25 2019-07-27 14:14:22 PDT

Created attachment 375034 [details] Patch

EWS Watchlist

Comment 26 2019-07-27 14:15:43 PDT Comment hidden (obsolete)

Attachment 375034 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826: Extra space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836: Extra space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 3 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 27 2019-07-27 15:33:12 PDT

FINALLY

Simon Fraser (smfr)

Comment 28 2019-07-28 13:25:07 PDT

Comment on attachment 375034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375034&action=review > Tools/ChangeLog:8 > + Instead of a mishmosh of #ifdefs and extraneous empty functions, mishmash? pishposh? oshkosh? > LayoutTests/swipe/resources/swipe-test.js:68 > + // FIXME: This test should probably not log playEventStream if it doesn't. doesn't what?

Tim Horton

Comment 29 2019-07-28 19:00:24 PDT

(In reply to Simon Fraser (smfr) from comment #28) > Comment on attachment 375034 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375034&action=review > > > Tools/ChangeLog:8 > > + Instead of a mishmosh of #ifdefs and extraneous empty functions, > > mishmash? pishposh? oshkosh? Probably all of the above. > > LayoutTests/swipe/resources/swipe-test.js:68 > > + // FIXME: This test should probably not log playEventStream if it doesn't. > > doesn't what? ... if it doesn't playEventStream!

Tim Horton

Comment 30 2019-07-28 19:11:34 PDT

https://trac.webkit.org/changeset/247898/webkit

Radar WebKit Bug Importer

Comment 31 2019-07-28 19:12:23 PDT

<rdar://problem/53644413>

Note You need to log in before you can comment on or make changes to this bug.