Bug 200024

Summary: [bmalloc] Each IsoPage gets 1MB VA because VMHeap::tryAllocateLargeChunk rounds up
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, ggaren, keith_miller, ljin.zq, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2019-07-22 18:46:32 PDT
Finally, we found the issue!
Attachments
Patch (14.10 KB, patch)
2019-07-22 19:30 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-07-22 18:46:57 PDT
<rdar://problem/53275201>
Yusuke Suzuki
Comment 2 2019-07-22 19:30:50 PDT
Created attachment 374665 [details] Patch
Saam Barati
Comment 3 2019-07-22 19:37:18 PDT
Comment on attachment 374665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review > Source/bmalloc/bmalloc/IsoPage.cpp:35 > + return tryVMAllocate(pageSize, pageSize, VMTag::IsoHeap); 👌
Mark Lam
Comment 4 2019-07-22 19:38:29 PDT
Comment on attachment 374665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review > Source/WebCore/page/ResourceUsageOverlay.h:61 > - static const int normalHeight = 160; > + static const int normalHeight = 180; Is this necessary?
Yusuke Suzuki
Comment 5 2019-07-22 19:39:47 PDT
Comment on attachment 374665 [details] Patch Thanks! Landing.
Yusuke Suzuki
Comment 6 2019-07-22 19:40:49 PDT
Comment on attachment 374665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review >> Source/WebCore/page/ResourceUsageOverlay.h:61 >> + static const int normalHeight = 180; > > Is this necessary? Without this change, ResourceOverlay failed to show all the categories since now we added IsoHeap data line :)
Yusuke Suzuki
Comment 7 2019-07-22 19:43:19 PDT
Committed r247714: <https://trac.webkit.org/changeset/247714>
Yusuke Suzuki
Comment 8 2019-09-21 02:09:08 PDT
*** Bug 202045 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.