Bug 200020

Summary: Make NetworkSession no longer RefCounted
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebKit Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, clopez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2019-07-22 17:13:55 PDT
This will simplify the object management model.
Attachments
Patch (27.73 KB, patch)
2019-07-22 17:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.41 KB, patch)
2019-07-22 18:53 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.76 KB, patch)
2019-07-24 14:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.76 KB, patch)
2019-07-24 14:25 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-07-22 17:30:09 PDT
Created attachment 374658 [details] Patch
youenn fablet
Comment 2 2019-07-22 18:53:35 PDT
Created attachment 374663 [details] Patch
Radar WebKit Bug Importer
Comment 3 2019-07-23 10:09:27 PDT
<rdar://problem/53451361>
Alex Christensen
Comment 4 2019-07-23 13:00:16 PDT
Comment on attachment 374663 [details] Patch I like it.
youenn fablet
Comment 5 2019-07-23 20:23:02 PDT
I probably am missing some if(m_networkSession). @cgarcia, could you look whether some are missing in GTK code?
Carlos Garcia Campos
Comment 6 2019-07-24 06:24:11 PDT
We need for sure a null check in the NetworkDataTask destructor, but I wonder if we need it everywhere m_session is used, or only in async completion handlers?
youenn fablet
Comment 7 2019-07-24 14:23:56 PDT
Created attachment 374810 [details] Patch
youenn fablet
Comment 8 2019-07-24 14:25:15 PDT
Created attachment 374811 [details] Patch
WebKit Commit Bot
Comment 9 2019-07-25 11:17:26 PDT
Comment on attachment 374811 [details] Patch Clearing flags on attachment: 374811 Committed r247831: <https://trac.webkit.org/changeset/247831>
WebKit Commit Bot
Comment 10 2019-07-25 11:17:28 PDT
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 11 2019-07-25 14:11:09 PDT
(In reply to WebKit Commit Bot from comment #9) > Comment on attachment 374811 [details] > Patch > > Clearing flags on attachment: 374811 > > Committed r247831: <https://trac.webkit.org/changeset/247831> Seems this broke GTK Debug build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/23203/steps/compile-webkit/logs/stdio
Carlos Garcia Campos
Comment 12 2019-07-26 00:54:51 PDT
(In reply to Carlos Alberto Lopez Perez from comment #11) > (In reply to WebKit Commit Bot from comment #9) > > Comment on attachment 374811 [details] > > Patch > > > > Clearing flags on attachment: 374811 > > > > Committed r247831: <https://trac.webkit.org/changeset/247831> > > Seems this broke GTK Debug build: > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/ > builds/23203/steps/compile-webkit/logs/stdio Fixed in r247856: <https://trac.webkit.org/changeset/247856>
youenn fablet
Comment 13 2019-07-26 09:20:10 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.