Bug 200015

Summary: resultsdbpy: Handle case where the previous commit doesn't have the changelog
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, kocsen_chung, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2019-07-22 14:42:15 PDT
Discovered this in a certain testing configuration. In practice, it's not actually a problem for real instances (at least right now) because we have to declare where all the changelogs are.
Attachments
Patch (1.56 KB, patch)
2019-07-22 14:50 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2019-07-22 15:56 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-07-22 14:50:00 PDT
Created attachment 374639 [details] Patch
Aakash Jain
Comment 2 2019-07-22 15:37:42 PDT
Comment on attachment 374639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374639&action=review What happens if current commit doesn't have ChangeLog? > Tools/resultsdbpy/resultsdbpy/model/repository.py:323 > if len(current_response.text) == (len(previous_response.text) if previous_response else 0): can we simplify this if-else, this is super confusing. Especially if someone doesn't pay very close attention to the order of parenthesis, this doesn't make sense. > Tools/resultsdbpy/resultsdbpy/model/repository.py:326 > + if not previous_response or len(current_response.text) < len(previous_response.text): Maybe just add another variable previous_response_length and evaluate it beforehand, so as to simplify both the if-else. something like: previous_response_length = 0 if previous_response: previous_response_length = len(previous_response.text)
Jonathan Bedard
Comment 3 2019-07-22 15:56:50 PDT
Created attachment 374645 [details] Patch
WebKit Commit Bot
Comment 4 2019-07-22 16:47:22 PDT
Comment on attachment 374645 [details] Patch Clearing flags on attachment: 374645 Committed r247706: <https://trac.webkit.org/changeset/247706>
WebKit Commit Bot
Comment 5 2019-07-22 16:47:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-22 16:48:16 PDT
<rdar://problem/53423137>
Note You need to log in before you can comment on or make changes to this bug.