Bug 199983 – [iOS WK2] Make a strongly-typed TransactionID to replace uint64_t transactionIDs

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

[iOS WK2] Make a strongly-typed TransactionID to replace uint64_t transactionIDs

[Simon Fraser (smfr)]

Created attachment 374563 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 374563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374563&action=review

> Source/WebKit/Shared/TransactionID.h:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

Oops

> Source/WebKit/Shared/TransactionID.h:36
> +template<typename T> class MonotonicObjectIdentifier {

Maybe MonotonicObjectIdentifier isn't the right name. I want "always increases by one".

[Simon Fraser (smfr)]

Created attachment 375058 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 377226 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377226 [details]
Patch

Clearing flags on attachment: 377226

Committed r249093: <https://trac.webkit.org/changeset/249093>

[Radar WebKit Bug Importer]

<rdar://problem/54725050>

[Darin Adler]

I’d like to find a way to adjust/tune ObjectIdentifier for this, and retire MonotonicObjectIdentifier.

[Simon Fraser (smfr)]

Maybe we can give ObjectIdentifier a trait for where its static uint64_t lives (shared with other ObjectIdentifiers or not).