Bug 199980

Summary:

[ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-07-20 10:45:50 PDT

ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests, only difference being the build-steps which are invoked on failure.

In https://ews-build.webkit.org/#/builders/18/builds/177 re-run-layout-tests had warnings (flaky tests), which should be considered a SUCCESS, but it was considered a FAILURE (and clean-tree was tested which is inefficient).

Comment 1 Aakash Jain 2019-07-20 10:49:32 PDT

Created attachment 374557 [details]
Patch

Comment 2 EWS Watchlist 2019-07-20 10:50:49 PDT Comment hidden (obsolete)

Attachment 374557 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1023:  [TestRunWebKitTests.test_parse_results_json_regression] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1024:  [TestRunWebKitTests.test_parse_results_json_regression] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1051:  [TestRunWebKitTests.test_parse_results_json_flakes] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1052:  [TestRunWebKitTests.test_parse_results_json_flakes] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1069:  [TestRunWebKitTests.test_parse_results_json_flakes_and_regressions] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1070:  [TestRunWebKitTests.test_parse_results_json_flakes_and_regressions] Instance of 'TestRunWebKitTests' has no 'assertEqual' member  [pylint/E1101] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2019-07-22 08:48:42 PDT

Comment on attachment 374557 [details]
Patch

Clearing flags on attachment: 374557

Committed r247683: <https://trac.webkit.org/changeset/247683>

Comment 4 WebKit Commit Bot 2019-07-22 08:48:43 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-07-22 08:49:18 PDT

<rdar://problem/53399568>