Bug 199974

Summary: Make sure the player underlying volume is correctly set after creating a new player
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200005    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-07-19 17:36:53 PDT
Make sure the player underlying volume is correctly set after creating a new player
Attachments
Patch (30.04 KB, patch)
2019-07-19 17:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.08 KB, patch)
2019-07-19 17:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.99 KB, patch)
2019-07-22 11:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-07-19 17:37:30 PDT
<rdar://problem/52762559>
youenn fablet
Comment 2 2019-07-19 17:49:07 PDT
Created attachment 374530 [details] Patch
Eric Carlson
Comment 3 2019-07-19 17:56:53 PDT
Comment on attachment 374530 [details] Patch r=me if the bots are happy with it.
youenn fablet
Comment 4 2019-07-19 17:58:16 PDT
Created attachment 374531 [details] Patch
youenn fablet
Comment 5 2019-07-19 18:03:08 PDT
While adding effectiveVolume, I did small changes to effectiveMuted. The effectiveMuted routine now checks for m_mediaController which was not the case before. This slightly change the behaviour in updatePlayState(). In case of m_mediaController , HTMLMediaElement::updateVolume() was setting the player muted state without considering its muted() state (but only m_mediaController and page states). I believe both changes are correct.
youenn fablet
Comment 6 2019-07-22 11:19:04 PDT
Created attachment 374610 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-07-22 13:03:12 PDT
Comment on attachment 374610 [details] Patch for landing Clearing flags on attachment: 374610 Committed r247698: <https://trac.webkit.org/changeset/247698>
WebKit Commit Bot
Comment 8 2019-07-22 13:03:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.