Summary: | Make sure the player underlying volume is correctly set after creating a new player | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 200005 | ||||||||||
Attachments: |
|
Description
youenn fablet
2019-07-19 17:36:53 PDT
Created attachment 374530 [details]
Patch
Comment on attachment 374530 [details]
Patch
r=me if the bots are happy with it.
Created attachment 374531 [details]
Patch
While adding effectiveVolume, I did small changes to effectiveMuted. The effectiveMuted routine now checks for m_mediaController which was not the case before. This slightly change the behaviour in updatePlayState(). In case of m_mediaController , HTMLMediaElement::updateVolume() was setting the player muted state without considering its muted() state (but only m_mediaController and page states). I believe both changes are correct. Created attachment 374610 [details]
Patch for landing
Comment on attachment 374610 [details] Patch for landing Clearing flags on attachment: 374610 Committed r247698: <https://trac.webkit.org/changeset/247698> All reviewed patches have been landed. Closing bug. |