| Summary: | Add accessibilityInsertText for text insertion in edit fields. | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-feeder, ews-watchlist, jcraig, jdiggs, rniwa, samuel_white | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Andres Gonzalez
2019-07-19 17:16:03 PDT
Created attachment 374529 [details]
Patch
Comment on attachment 374529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374529&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2289 > + if (element.shouldUseInputMethod()) { we should do early return styleher if (!element.shouldUseInputMethod()) return false; > Source/WebCore/accessibility/AccessibilityObject.h:717 > + bool insertText(const String& text); no need to name parameter here > LayoutTests/accessibility/insert-newline.html:16 > + content.focus(); is this the same exact test on iOS? if so we can probably share it in accessibility folder and skip on other platforms Created attachment 374534 [details]
Patch
All comments addressed. Thanks. Comment on attachment 374534 [details]
Patch
We probably need to skip this on gtk and friends
Comment on attachment 374534 [details] Patch Attachment 374534 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12777379 New failing tests: accessibility/insert-newline.html Created attachment 374537 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 374534 [details] Patch Attachment 374534 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12777526 New failing tests: accessibility/insert-newline.html Created attachment 374538 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 374534 [details] Patch Attachment 374534 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12777561 New failing tests: accessibility/insert-newline.html Created attachment 374540 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 374556 [details]
Patch
<rdar://problem/52146108> When composing a reply to an email with a braille display's keyboard', the cursor will often jump around Created attachment 374558 [details]
Patch
Comment on attachment 374558 [details] Patch Attachment 374558 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12780641 New failing tests: accessibility/insert-newline.html Created attachment 374561 [details]
Archive of layout-test-results from ews210 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 374562 [details]
Patch
Comment on attachment 374562 [details] Patch Rejecting attachment 374562 [details] from review queue. andresg_22@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 374562 [details] Patch Clearing flags on attachment: 374562 Committed r247671: <https://trac.webkit.org/changeset/247671> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 374570 [details]
Patch
Created attachment 374578 [details]
Patch
Comment on attachment 374578 [details] Patch Clearing flags on attachment: 374578 Committed r247677: <https://trac.webkit.org/changeset/247677> All reviewed patches have been landed. Closing bug. |