Bug 199971

Summary: REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jer Noble 2019-07-19 15:59:17 PDT
REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
Comment 1 Jer Noble 2019-07-19 16:00:27 PDT
<rdar://problem/51951218>
Comment 2 Jer Noble 2019-07-19 16:04:37 PDT
Created attachment 374516 [details]
Patch
Comment 3 Alex Christensen 2019-07-19 16:11:31 PDT
Comment on attachment 374516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374516&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:28
> +#if PLATFORM(IOS_FAMILY)

If this works on Mac, let's increase our coverage.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:44
> +    RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:50
> +    RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 300, 300) configuration:configuration.get() addToWindow:YES]);

auto
Comment 4 Jer Noble 2019-07-19 16:20:44 PDT
Created attachment 374520 [details]
Patch
Comment 5 Jer Noble 2019-07-22 11:17:08 PDT
Created attachment 374608 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-22 12:38:11 PDT
Comment on attachment 374608 [details]
Patch

Clearing flags on attachment: 374608

Committed r247695: <https://trac.webkit.org/changeset/247695>
Comment 7 WebKit Commit Bot 2019-07-22 12:38:13 PDT
All reviewed patches have been landed.  Closing bug.