| Summary: | Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebKit Misc. | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2019-07-19 09:59:57 PDT
Created attachment 374472 [details]
Patch
*** Bug 199919 has been marked as a duplicate of this bug. *** Created attachment 374533 [details]
Patch
Comment on attachment 374533 [details]
Patch
Sure. I think it would be a little more consistent with the rest of the code to check the weak pointer in the lambda, then pass a NetworkSessionCocoa& to processServerTrustEvaluation.
Created attachment 374606 [details]
Patch for landing
(In reply to Alex Christensen from comment #4) > Comment on attachment 374533 [details] > Patch > > Sure. I think it would be a little more consistent with the rest of the > code to check the weak pointer in the lambda, then pass a > NetworkSessionCocoa& to processServerTrustEvaluation. Done. Comment on attachment 374606 [details] Patch for landing Clearing flags on attachment: 374606 Committed r247693: <https://trac.webkit.org/changeset/247693> All reviewed patches have been landed. Closing bug. |