Bug 199948

Summary: Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebKit Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-07-19 09:59:57 PDT
Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread
Attachments
Patch (3.62 KB, patch)
2019-07-19 10:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2019-07-19 18:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.67 KB, patch)
2019-07-22 11:02 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-07-19 10:03:49 PDT
Created attachment 374472 [details] Patch
youenn fablet
Comment 2 2019-07-19 10:50:24 PDT
*** Bug 199919 has been marked as a duplicate of this bug. ***
youenn fablet
Comment 3 2019-07-19 18:24:39 PDT
Created attachment 374533 [details] Patch
Alex Christensen
Comment 4 2019-07-22 10:33:43 PDT
Comment on attachment 374533 [details] Patch Sure. I think it would be a little more consistent with the rest of the code to check the weak pointer in the lambda, then pass a NetworkSessionCocoa& to processServerTrustEvaluation.
youenn fablet
Comment 5 2019-07-22 11:02:18 PDT
Created attachment 374606 [details] Patch for landing
youenn fablet
Comment 6 2019-07-22 11:04:31 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 374533 [details] > Patch > > Sure. I think it would be a little more consistent with the rest of the > code to check the weak pointer in the lambda, then pass a > NetworkSessionCocoa& to processServerTrustEvaluation. Done.
WebKit Commit Bot
Comment 7 2019-07-22 11:51:37 PDT
Comment on attachment 374606 [details] Patch for landing Clearing flags on attachment: 374606 Committed r247693: <https://trac.webkit.org/changeset/247693>
WebKit Commit Bot
Comment 8 2019-07-22 11:51:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-07-22 11:52:20 PDT
<rdar://problem/53408892>
Note You need to log in before you can comment on or make changes to this bug.