Summary: | [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bugs-noreply, cgarcia, ews-watchlist, glenn, mcatanzaro, pnormand, webkit-bug-importer, zan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=199855 | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2019-07-19 08:52:19 PDT
Created attachment 374468 [details]
Patch
Comment on attachment 374468 [details] Patch Clearing flags on attachment: 374468 Committed r247663: <https://trac.webkit.org/changeset/247663> All reviewed patches have been landed. Closing bug. On further thinking, it seems to me that is also worth also adding an unit test for this. Created attachment 374597 [details]
Patch
Comment on attachment 374597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374597&action=review > Tools/Scripts/webkitpy/port/driver_unittest.py:396 > + self.assertNotEqual(environ_driver[var], None) > + > + > def test_create_temporal_home_dir(self): All the other surrounding functions have only one line between them (though I thought two was supposed to be standard for python). Committed r247682: <https://trac.webkit.org/changeset/247682> |