Bug 199940

Summary: Add a menu item to toggle between showing and hiding link previews
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch bdakin: review+

Dean Jackson
Reported 2019-07-19 05:44:44 PDT
Add a menu item to toggle between showing and hiding link previews
Attachments
Patch (16.87 KB, patch)
2019-07-19 05:56 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (18.11 KB, patch)
2019-07-19 07:45 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (19.38 KB, patch)
2019-07-19 08:07 PDT, Dean Jackson 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2019-07-19 05:45:14 PDT
<rdar://problem/53032288>
Dean Jackson
Comment 2 2019-07-19 05:56:00 PDT
Created attachment 374460 [details] Patch
Dean Jackson
Comment 3 2019-07-19 07:45:40 PDT
Created attachment 374465 [details] Patch
Dean Jackson
Comment 4 2019-07-19 08:07:25 PDT
Created attachment 374466 [details] Patch
Beth Dakin
Comment 5 2019-07-19 10:13:53 PDT
Comment on attachment 374466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374466&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7674 > + if (!originalMenu) Is there ever a case when a menu would no items would be represented by a nil menu? I just want to make sure that if a client removes ALL of the menu items, we still provide this one.
Dean Jackson
Comment 6 2019-07-19 12:15:28 PDT
Comment on attachment 374466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374466&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7674 >> + if (!originalMenu) > > Is there ever a case when a menu would no items would be represented by a nil menu? I just want to make sure that if a client removes ALL of the menu items, we still provide this one. Good point! Yes, if they remove all the items (which they technically shouldn't do) we have to provide this one. I used to have code where we'd provide all the default actions if they removed everything. I'll make sure that still happens, since that's what HI wanted.
Dean Jackson
Comment 7 2019-07-19 14:18:22 PDT
Committed r247652: <https://trac.webkit.org/changeset/247652>
Note You need to log in before you can comment on or make changes to this bug.