Bug 199932
| Summary: | [WHLSL] Global struct has too many unused members in it | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> |
| Component: | WebGPU | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | saam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 200463 | ||
| Bug Blocks: | |||
Myles C. Maxfield
There are hundreds of members, almost none of which are used.
We should gather items in the global struct per entry point, and only in functions which are reachable from that entry point, rather than gathering them across the whole program.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
(In reply to Myles C. Maxfield from comment #0)
> There are hundreds of members, almost none of which are used.
>
> We should gather items in the global struct per entry point, and only in
> functions which are reachable from that entry point, rather than gathering
> them across the whole program.
We’d also greatly reduce the number if we marked the various take the address of nodes we generate internally with a special bit that they don’t need to be in the struct. same if we skipped stdlib functions
Myles C. Maxfield
WHLSL is no longer relevant.