Bug 199926

Summary:

[bmalloc] Dump more information when exhausting VA in IsoHeap

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

bmalloc

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

NEW

Severity:

Normal

CC:

ews-watchlist, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Yusuke Suzuki

Reported 2019-07-18 18:19:35 PDT

...

Attachments
Patch (26.00 KB, patch) 2019-07-22 16:20 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (26.11 KB, patch) 2019-07-22 17:25 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (26.48 KB, patch) 2019-07-22 18:16 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (26.50 KB, patch) 2019-07-22 18:24 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2019-07-22 16:20:06 PDT

Created attachment 374650 [details] Patch

Yusuke Suzuki

Comment 2 2019-07-22 16:25:41 PDT

<rdar://problem/53422069>

Yusuke Suzuki

Comment 3 2019-07-22 17:25:33 PDT

Created attachment 374657 [details] Patch WIP

EWS Watchlist

Comment 4 2019-07-22 17:27:10 PDT

Attachment 374657 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BAssert.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:127: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 5 2019-07-22 18:16:15 PDT

Created attachment 374659 [details] Patch WIP

EWS Watchlist

Comment 6 2019-07-22 18:19:04 PDT

Attachment 374659 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BAssert.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:127: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 7 2019-07-22 18:24:50 PDT

Created attachment 374661 [details] Patch WIP

EWS Watchlist

Comment 8 2019-07-22 18:27:05 PDT

Attachment 374661 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/BAssert.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:120: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/bmalloc/bmalloc/BAssert.cpp:127: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 9 2019-07-22 19:13:45 PDT

I'll use a part of this in bug 200024.

Note You need to log in before you can comment on or make changes to this bug.