Bug 199889

Summary: Unable to bring up custom media controls on iOS for video.sina.cn
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ryanhaddad, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2019-07-17 16:09:23 PDT
Unable to bring up custom media controls on iOS for video.sina.cn
Attachments
Patch (9.28 KB, patch)
2019-07-17 16:19 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.75 KB, patch)
2019-07-19 07:33 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-07-17 16:19:47 PDT
Created attachment 374347 [details] Patch
Antoine Quint
Comment 2 2019-07-17 16:22:43 PDT
<rdar://problem/51883919>
Antoine Quint
Comment 3 2019-07-17 16:57:38 PDT
Committed r247544: <https://trac.webkit.org/changeset/247544>
Ryan Haddad
Comment 4 2019-07-18 17:55:04 PDT
The test added with this change is consistently timing out on iOS Simulator bots: media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls.html
Antoine Quint
Comment 5 2019-07-19 07:28:25 PDT
(In reply to Ryan Haddad from comment #4) > The test added with this change is consistently timing out on iOS Simulator > bots: > media/modern-media-controls/media-controller/ios/media-controller-allows- > click-over-video-with-no-controls.html > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia- > controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls. > html That's right, this should be skipped on OpenSource bots. I'll get to it later today.
Antoine Quint
Comment 6 2019-07-19 07:33:32 PDT
Reopening to attach new patch.
Antoine Quint
Comment 7 2019-07-19 07:33:34 PDT
Created attachment 374463 [details] Patch for landing
WebKit Commit Bot
Comment 8 2019-07-19 08:51:45 PDT
Comment on attachment 374463 [details] Patch for landing Clearing flags on attachment: 374463 Committed r247645: <https://trac.webkit.org/changeset/247645>
WebKit Commit Bot
Comment 9 2019-07-19 08:51:47 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 10 2019-07-19 09:44:45 PDT
It looks like the new test media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html added in https://trac.webkit.org/changeset/247612/webkit Is timing out on iOS. history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls.html
Truitt Savell
Comment 11 2019-07-19 09:46:08 PDT
Just realized the patch for this just landed and hasn't hit the bots. disregard me, sorry.
Note You need to log in before you can comment on or make changes to this bug.