Summary: | Provide a NSURL cateogry to tell AppSSO Kerberos URLs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, conrad_shultz, jiewen_tan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jiewen Tan
2019-07-17 15:34:01 PDT
Created attachment 374344 [details]
Patch
Comment on attachment 374344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 > ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something. Comment on attachment 374344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review >> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 >> ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url > > Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? > > That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something. Thanks, Brent. I made it + (BOOL)_web_willPerformSOKerberosAuthorizationWithURL:(NSURL *)url. Created attachment 374351 [details]
Patch
Comment on attachment 374351 [details]
Patch
Thanks for changing the naming.
(In reply to Brent Fulgham from comment #6) > Comment on attachment 374351 [details] > Patch > > Thanks for changing the naming. Thanks for r+ it. Comment on attachment 374351 [details] Patch Clearing flags on attachment: 374351 Committed r247547: <https://trac.webkit.org/changeset/247547> All reviewed patches have been landed. Closing bug. |