Bug 199887

Summary: Provide a NSURL cateogry to tell AppSSO Kerberos URLs
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, conrad_shultz, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jiewen Tan
Reported 2019-07-17 15:34:01 PDT
Provide a NSURL cateogry to tell AppSSO Kerberos URLs.
Attachments
Patch (2.42 KB, patch)
2019-07-17 15:42 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2019-07-17 16:52 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2019-07-17 15:34:31 PDT
<rdar://problem/52323161>
Jiewen Tan
Comment 2 2019-07-17 15:42:49 PDT
Created attachment 374344 [details] Patch
Brent Fulgham
Comment 3 2019-07-17 15:54:32 PDT
Comment on attachment 374344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 > ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something.
Jiewen Tan
Comment 4 2019-07-17 16:40:43 PDT
Comment on attachment 374344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review >> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42 >> ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url > > Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way? > > That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something. Thanks, Brent. I made it + (BOOL)_web_willPerformSOKerberosAuthorizationWithURL:(NSURL *)url.
Jiewen Tan
Comment 5 2019-07-17 16:52:49 PDT
Created attachment 374351 [details] Patch
Brent Fulgham
Comment 6 2019-07-17 16:53:28 PDT
Comment on attachment 374351 [details] Patch Thanks for changing the naming.
Jiewen Tan
Comment 7 2019-07-17 16:54:39 PDT
(In reply to Brent Fulgham from comment #6) > Comment on attachment 374351 [details] > Patch > > Thanks for changing the naming. Thanks for r+ it.
WebKit Commit Bot
Comment 8 2019-07-17 17:15:07 PDT
Comment on attachment 374351 [details] Patch Clearing flags on attachment: 374351 Committed r247547: <https://trac.webkit.org/changeset/247547>
WebKit Commit Bot
Comment 9 2019-07-17 17:15:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.