Bug 199875

Summary: Rebase fast/forms/ios/delete-in-input-in-iframe.html after r244141
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2019-07-17 12:20:37 PDT
Revert part of r244141
Attachments
Patch (1.54 KB, patch)
2019-07-17 12:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2019-07-17 13:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2019-07-18 11:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2019-07-18 15:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-07-17 12:21:48 PDT
Created attachment 374313 [details] Patch
Alex Christensen
Comment 2 2019-07-17 12:35:39 PDT
rdar://problem/50060561
Tim Horton
Comment 3 2019-07-17 12:46:18 PDT
Comment on attachment 374313 [details] Patch This needs a changelog with a minimum of 500 words.
Alex Christensen
Comment 4 2019-07-17 13:26:49 PDT
Created attachment 374322 [details] Patch
Tim Horton
Comment 5 2019-07-17 13:29:08 PDT
Comment on attachment 374322 [details] Patch This is a so much better change
Megan Gardner
Comment 6 2019-07-18 11:10:49 PDT
Comment on attachment 374322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374322&action=review Yes, much, much better, thanks for looking into this! > LayoutTests/ChangeLog:5 > + Radar?
Megan Gardner
Comment 7 2019-07-18 11:11:43 PDT
Comment on attachment 374322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374322&action=review > LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt:3 > +PASS: page scrolled to 1143 Do we want to consider just testing to see if the page scrolled at all, rather than to a specific number? This seems prone to regressions still.
Alex Christensen
Comment 8 2019-07-18 11:23:58 PDT
Comment on attachment 374322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374322&action=review >> LayoutTests/fast/forms/ios/delete-in-input-in-iframe-expected.txt:3 >> +PASS: page scrolled to 1143 > > Do we want to consider just testing to see if the page scrolled at all, rather than to a specific number? This seems prone to regressions still. I thought this was better so we can verify that it scrolled the expected amount. If this becomes flaky or we change the scrolling amount too much we can change the results later
Alex Christensen
Comment 9 2019-07-18 11:27:30 PDT
Created attachment 374398 [details] Patch
WebKit Commit Bot
Comment 10 2019-07-18 12:06:41 PDT
Comment on attachment 374398 [details] Patch Clearing flags on attachment: 374398 Committed r247571: <https://trac.webkit.org/changeset/247571>
WebKit Commit Bot
Comment 11 2019-07-18 12:06:43 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 12 2019-07-18 15:42:09 PDT
*** Bug 199920 has been marked as a duplicate of this bug. ***
Alex Christensen
Comment 13 2019-07-18 15:43:01 PDT
Reopening to attach new patch.
Alex Christensen
Comment 14 2019-07-18 15:43:02 PDT
Created attachment 374422 [details] Patch
WebKit Commit Bot
Comment 15 2019-07-19 09:56:06 PDT
Comment on attachment 374422 [details] Patch Clearing flags on attachment: 374422 Committed r247648: <https://trac.webkit.org/changeset/247648>
WebKit Commit Bot
Comment 16 2019-07-19 09:56:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.