Bug 199837

Summary: results.webkit.org: Move resultsdbpy to WebKit
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, kocsen_chung, lforschler, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-07-16 14:32:40 PDT
We have a results-database that we've been using Internally for a few months that we would like begin the process of replacing the flakiness dashboard <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html> with. The first step in this process is to migrate the bulk of the code supporting this database into WebKit.
Attachments
Patch (645.41 KB, patch)
2019-07-17 15:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (645.71 KB, patch)
2019-07-18 16:37 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (645.73 KB, patch)
2019-07-18 17:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-16 14:33:05 PDT
<rdar://problem/53172130>
Jonathan Bedard
Comment 2 2019-07-17 15:24:29 PDT
Created attachment 374338 [details] Patch
Jonathan Bedard
Comment 3 2019-07-18 16:37:48 PDT
Created attachment 374428 [details] Patch
Aakash Jain
Comment 4 2019-07-18 16:57:27 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=374338&action=review rs=me > Tools/resultsdbpy/resultsdbpy/controller/configuration.py:58 > + self.sdk = None if not sdk or sdk == '?' else str(sdk) I always find multi-line if-else easier to understand and less error-prone. Might be a good idea to convert this to multi-line, something like: self.sdk = None if sdk and sdk != '?': self.sdk = str(sdk)
Jonathan Bedard
Comment 5 2019-07-18 17:03:25 PDT
Created attachment 374429 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-07-18 18:34:46 PDT
Comment on attachment 374429 [details] Patch for landing Clearing flags on attachment: 374429 Committed r247628: <https://trac.webkit.org/changeset/247628>
WebKit Commit Bot
Comment 7 2019-07-18 18:34:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.