Summary: | Add release logging to AudioSampleDataSource | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=198545 | ||||||||
Attachments: |
|
Description
youenn fablet
2019-07-15 16:33:17 PDT
Created attachment 374174 [details]
Patch
Comment on attachment 374174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374174&action=review > Source/WebCore/ChangeLog:16 > + In that case, we change of logger when changing of MediaStreamTrackPrivate. Nit: s/change of logger when changing of/change the logger when changing the/ > Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:278 > + ALWAYS_LOG("sample ", timeStamp, " is not completely in range [", startFrame, " .. ", endFrame, "], returning ", framesAvailable, " frames"); > + if (framesAvailable < sampleCount) > + ALWAYS_LOG("not enough data available, returning zeroes"); Nit: should these be ERROR_LOG? Created attachment 374295 [details]
Patch for landing
Comment on attachment 374295 [details] Patch for landing Clearing flags on attachment: 374295 Committed r247522: <https://trac.webkit.org/changeset/247522> All reviewed patches have been landed. Closing bug. |